MAINT: Avoid deselecting valid KNN conformance tests for nan_euclidean #2834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/intelci: run |
Contributor
Author
|
/intelci: run |
This reverts commit e9012b7.
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
icfaust
approved these changes
Dec 8, 2025
Contributor
icfaust
left a comment
icfaust
left a comment
There was a problem hiding this comment.
good catch. man this was a bad one.
Contributor
Author
|
/intelci: run |
Contributor
Author
|
/azp run Nightly |
|
Azure Pipelines successfully started running 1 pipeline(s). |
david-cortes-intel
changed the title
david-cortes-intel
requested review from
ahuber21,
ethanglaser and
yuejiaointel
as code owners
david-cortes-intel
merged commit e54fd87
into
uxlfoundation:main
32 of 39 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some scikit-learn tests for KNN with metric
nan_euclideanare deselected. These should work correctly by falling back to stock sklearn.This PR removes the deselections.
Checklist:
Completeness and readability
Testing