Skip to content

Conversation

@e-kwsm
Copy link
Contributor

@e-kwsm e-kwsm commented Jan 21, 2026

  • correct input and expected output strings
    use ANSI-C strings to interpret \n
  • unquote sed_script

run_sed_test "print_line" "-n 2p" "line1\nline2\nline3" "line2" "-n"

requires to unquote options:

--- main
+++ this PR
- ./target/release/sed -n '-n 2p' input.txt
+ ./target/release/sed -n -n 2p input.txt

Note that print_line still fails due to multiple -n.

@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.11%. Comparing base (c6479b4) to head (fc39ff7).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #268   +/-   ##
=======================================
  Coverage   82.11%   82.11%           
=======================================
  Files          13       13           
  Lines        5327     5327           
  Branches      294      294           
=======================================
  Hits         4374     4374           
  Misses        951      951           
  Partials        2        2           
Flag Coverage Δ
macos_latest 82.54% <ø> (ø)
ubuntu_latest 82.66% <ø> (ø)
windows_latest 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

GNU sed testsuite comparison:

Test results comparison:
  Current:   TOTAL: 64 / PASSED: 15 / FAILED: 49 / SKIPPED: 0
  Reference: TOTAL: 64 / PASSED: 8 / FAILED: 56 / SKIPPED: 0

Changes from main branch:
  TOTAL: +0
  PASSED: +7
  FAILED: -7

Test improvements (7):
  + append
  + delete_line
  + delete_range
  + insert
  + line_address
  + range_address
  + word_class

@sylvestre
Copy link
Contributor

oh nice :)

@sylvestre sylvestre merged commit c5e6348 into uutils:main Jan 21, 2026
27 checks passed
@e-kwsm e-kwsm deleted the run-gnu-testsuite.sh branch January 21, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants