Improve command range handling #267
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
a few tests are failing :) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
==========================================
- Coverage 82.11% 82.03% -0.08%
==========================================
Files 13 13
Lines 5327 5423 +96
Branches 294 291 -3
==========================================
+ Hits 4374 4449 +75
- Misses 951 972 +21
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
GNU sed testsuite comparison: |
Collaborator
Author
|
On it. |
dspinellis
force-pushed
the
last-line
branch
2 times, most recently
from
8ad52fb to
2bf6a94
Compare
|
GNU sed testsuite comparison: |
Collaborator
Author
|
@sylvestre I fixed the issue. |
|
GNU sed testsuite comparison: |
|
GNU sed testsuite comparison: |
Merging this PR will degrade performance by 3.47%
Performance Changes
Comparing 
|
|
GNU sed testsuite comparison: |
Before this commit, the output of sed was lagging one line behind, as it was always checking whether each line was the last one ($). This change modifies the behavior to make this check only when actually needed. This brings sed's interactive behavior (when reading from a terminal) in line with the GNU and FreeBSD implementations.
This is a GNU extension that starts the range as latched. While at it, also fix the handling of ranges straddling independent files.
This removes invalid states and simplifies pattern matching. It also makes it easier to add further address extensions.
|
GNU sed testsuite comparison: |
1 similar comment
|
GNU sed testsuite comparison: |
|
GNU sed testsuite comparison: |
Collaborator
Author
|
@sylvestre This PR is now ready for review. I don't have anything related to add to it. Will work on further GNU compatibility improvements once this gets merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, the output of sed was lagging one line behind, as it was always checking whether each line was the last one ($). This change modifies the behavior to perform this check only when actually needed. This brings sed's interactive behavior (when reading from a terminal) in line with the GNU and FreeBSD implementations.
In addition this PR adds support for the GNU address 0 extension and for ~step ranges. To support this it refactors the address representation.