Skip to content

Conversation

@sylvestre
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 11, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.04%. Comparing base (1710d9c) to head (d4afc8f).

Files with missing lines Patch % Lines
src/sed/processor.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
- Coverage   82.11%   82.04%   -0.07%     
==========================================
  Files          13       13              
  Lines        5327     5331       +4     
  Branches      294      294              
==========================================
  Hits         4374     4374              
- Misses        951      955       +4     
  Partials        2        2              
Flag Coverage Δ
macos_latest 82.48% <0.00%> (-0.07%) ⬇️
ubuntu_latest 82.60% <0.00%> (-0.07%) ⬇️
windows_latest 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 11, 2026

CodSpeed Performance Report

Merging this PR will improve performance by 5.97%

Comparing sylvestre:del (d4afc8f) with main (1710d9c)

Summary

⚡ 1 improved benchmark
✅ 10 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
access_log_all_del 542.1 ms 511.5 ms +5.97%

- Add pattern_deleted flag to ProcessingContext to prevent automatic
  pattern printing after 'd', 'D', and 'c' commands
- Fix test framework to properly interpret escape sequences with echo -e
- Correct test expectations for print_line and word_class tests
- Add comprehensive unit tests for delete command behavior
@github-actions
Copy link

GNU sed testsuite comparison:

Test results comparison:
  Current:   TOTAL: 64 / PASSED: 13 / FAILED: 51 / SKIPPED: 0
  Reference: TOTAL: 64 / PASSED: 8 / FAILED: 56 / SKIPPED: 0

Changes from main branch:
  TOTAL: +0
  PASSED: +5
  FAILED: -5

New test failures (3):
  - execute-tests_n_3
  - madding_triplet
  - uniq_triplet

Test improvements (8):
  + append
  + delete_line
  + delete_range
  + insert
  + line_address
  + print_line
  + range_address
  + word_class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant