Skip to content

fix install file with invalid uid #7789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zhw2101024 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix install file with invalid uid #7789

zhw2101024 wants to merge 2 commits into from
+103 −2

Conversation

@zhw2101024
Copy link
Contributor

@zhw2101024 zhw2101024 commented Apr 19, 2025 •
edited
Loading

fixes #7879

@sylvestre
Copy link
Contributor

sylvestre commented Apr 19, 2025

Could you please add a test to make sure we don't regress? Thanks

@zhw2101024 zhw2101024 force-pushed the test_install_root_combined branch 2 times, most recently from fa60b65 to 65d1bb6 Compare April 20, 2025 05:51
@zhw2101024
Copy link
Contributor Author

zhw2101024 commented Apr 20, 2025

Could you please add a test to make sure we don't regress? Thanks

Finished the test.

@zhw2101024 zhw2101024 force-pushed the test_install_root_combined branch from 65d1bb6 to f87aa34 Compare April 20, 2025 06:03
@github-actions
Copy link

github-actions bot commented Apr 20, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@zhw2101024 zhw2101024 force-pushed the test_install_root_combined branch 3 times, most recently from 961eec9 to 2dd5646 Compare April 21, 2025 05:54
@github-actions
Copy link

github-actions bot commented Apr 21, 2025

GNU testsuite comparison:

GNU test failed: tests/misc/tee. tests/misc/tee is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)

@zhw2101024 zhw2101024 force-pushed the test_install_root_combined branch from 2dd5646 to 6d1e62c Compare April 21, 2025 09:41
@github-actions
Copy link

github-actions bot commented Apr 21, 2025

GNU testsuite comparison:

GNU test failed: tests/misc/tee. tests/misc/tee is passing on 'main'. Maybe you have to rebase?

@zhw2101024 zhw2101024 force-pushed the test_install_root_combined branch from 6d1e62c to 76477ee Compare April 21, 2025 13:50
@github-actions
Copy link

github-actions bot commented Apr 21, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

@zhw2101024 zhw2101024 mentioned this pull request Apr 22, 2025
Closed
@zhw2101024 zhw2101024 force-pushed the test_install_root_combined branch from 76477ee to 33830bb Compare April 27, 2025 06:48
@github-actions
Copy link

github-actions bot commented Apr 27, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

@sylvestre sylvestre force-pushed the test_install_root_combined branch from 33830bb to 054dc17 Compare April 27, 2025 21:54
@sylvestre
Copy link
Contributor

sylvestre commented Apr 27, 2025

many jobs are failing

@github-actions
Copy link

github-actions bot commented Apr 27, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/rm/empty-inacc is no longer failing!

@zhw2101024 zhw2101024 force-pushed the test_install_root_combined branch from 054dc17 to dde3ee9 Compare April 28, 2025 03:31
@github-actions
Copy link

github-actions bot commented Apr 28, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

@zhw2101024
Copy link
Contributor Author

zhw2101024 commented Apr 28, 2025

many jobs are failing

Caused by some rebase issues, fixed it now. By the way, the test in this PR need to ensure that there's no user with userid 500 on the system, maybe I can modify the userid in the prepare stage of CICD runners?

@jtracey
Copy link
Contributor

jtracey commented Apr 29, 2025

I don't think you need to configure the system, you can just avoid hardcoding 500 and instead use the first UID not in /etc/passwd.

@zhw2101024 zhw2101024 force-pushed the test_install_root_combined branch from dde3ee9 to ee47432 Compare April 30, 2025 13:52
@zhw2101024
Copy link
Contributor Author

zhw2101024 commented Apr 30, 2025 •
edited
Loading

I don't think you need to configure the system, you can just avoid hardcoding 500 and instead use the first UID not in /etc/passwd.

I'm using a long script to get a uid not in /etc/passwd, so adding subprocess to use the Exec::shell method.
cat /etc/passwd|cut -d ':' -f 3|grep '^1...$'|sort -n|tail -n 1|awk '{print $1+1}'

@zhw2101024 zhw2101024 force-pushed the test_install_root_combined branch 4 times, most recently from 74b9db7 to 9f73173 Compare April 30, 2025 14:22
@zhw2101024 zhw2101024 force-pushed the test_install_root_combined branch from 026cc13 to ba1dc38 Compare October 21, 2025 02:09
@github-actions
Copy link

github-actions bot commented Oct 21, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/rm/rm1 (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@zhw2101024
Copy link
Contributor Author

zhw2101024 commented Oct 21, 2025

@sylvestre Hi, all conversations resolved an all checks passed, please check if the comments are applicable.

sylvestre
sylvestre reviewed Nov 15, 2025
View reviewed changes
sylvestre
sylvestre reviewed Nov 15, 2025
View reviewed changes
@zhw2101024 zhw2101024 force-pushed the test_install_root_combined branch from ba1dc38 to 709e36c Compare November 16, 2025 06:56
@github-actions
Copy link

github-actions bot commented Nov 16, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@zhw2101024 zhw2101024 force-pushed the test_install_root_combined branch 2 times, most recently from 9315602 to 70c4ecd Compare November 16, 2025 07:26
@github-actions
Copy link

github-actions bot commented Nov 16, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

@zhw2101024
Copy link
Contributor Author

zhw2101024 commented Nov 16, 2025

@sylvestre All checks passed, thans for your conversations!

@zhw2101024 zhw2101024 force-pushed the test_install_root_combined branch from 70c4ecd to b4907d9 Compare November 29, 2025 13:24
@github-actions
Copy link

github-actions bot commented Nov 29, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@zhw2101024 zhw2101024 force-pushed the test_install_root_combined branch from b4907d9 to 3eca983 Compare December 8, 2025 02:38
@github-actions
Copy link

github-actions bot commented Dec 8, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/stty/stty-invalid is now passing!
Congrats! The gnu test tests/stty/stty-pairs is now passing!
Note: The gnu test tests/mv/i-3 was skipped on 'main' but is now failing.
Note: The gnu test tests/stty/stty was skipped on 'main' but is now failing.
Note: The gnu test tests/stty/stty-row-col was skipped on 'main' but is now failing.

@zhw2101024 zhw2101024 force-pushed the test_install_root_combined branch from 3eca983 to 7c58a44 Compare December 9, 2025 07:16
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cksum/b2sum is no longer failing!

@zhw2101024 zhw2101024 force-pushed the test_install_root_combined branch from 7c58a44 to e7b56c7 Compare December 9, 2025 15:02
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cksum/b2sum is no longer failing!

@zhw2101024 zhw2101024 force-pushed the test_install_root_combined branch from e7b56c7 to 16c5c50 Compare December 11, 2025 02:46
@github-actions
Copy link

github-actions bot commented Dec 11, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@zhw2101024 zhw2101024 force-pushed the test_install_root_combined branch 2 times, most recently from 53dde80 to d28c379 Compare January 1, 2026 08:29
@github-actions
Copy link

github-actions bot commented Jan 1, 2026

GNU testsuite comparison:

Congrats! The gnu test tests/shuf/shuf-reservoir is no longer failing!
Congrats! The gnu test tests/sort/sort-stale-thread-mem is no longer failing!

@zhw2101024
Copy link
Contributor Author

zhw2101024 commented Jan 1, 2026

Hi, i just rebased the fix branch with the main branch, and all tests passed. Thanks for your time.

@sylvestre
Copy link
Contributor

sylvestre commented Jan 1, 2026

Are you sure? on my system:

LANG=C /usr/bin/install -o 1100 a b2222
install: cannot change ownership of 'b2222': Operation not permitted

@zhw2101024
Copy link
Contributor Author

zhw2101024 commented Jan 1, 2026

Are you sure? on my system:

LANG=C /usr/bin/install -o 1100 a b2222
install: cannot change ownership of 'b2222': Operation not permitted

The manpage says the owner option of install is for super-user only, maybe we need to test this option with the root user.

@zhw2101024 zhw2101024 force-pushed the test_install_root_combined branch from d28c379 to 517fb30 Compare January 11, 2026 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sylvestre sylvestre sylvestre left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

install: incorrectly install file with userid not used

3 participants

@zhw2101024 @sylvestre @jtracey