Skip to content

uucore::pipes::splice_exact: improve document#12414

Open
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:splice-exact-doc
Open

uucore::pipes::splice_exact: improve document#12414
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:splice-exact-doc

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented May 21, 2026

I previously said this function is dangerous since it does not return bytes sent. But actually, we can make pipe empty when splice_exact() failed by reading the pipe until EOF.

But add document to avoid misreading.

Also this function does not panic.

@oech3 oech3 marked this pull request as ready for review May 21, 2026 09:46
@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/cut/cut-huge-range is now passing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant