Skip to content

yes: dedup some logic#11536

Open
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:yes-dedup
Open

yes: dedup some logic#11536
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:yes-dedup

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented Mar 28, 2026

No description provided.

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/misc/io-errors is no longer failing!
Congrats! The gnu test tests/unexpand/bounded-memory is now passing!

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 28, 2026

Merging this PR will not alter performance

✅ 302 untouched benchmarks
⏩ 46 skipped benchmarks1


Comparing oech3:yes-dedup (5da01c8) with main (12485f2)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3 oech3 marked this pull request as ready for review March 28, 2026 18:52
@sylvestre
Copy link
Copy Markdown
Contributor

i found your commit message a bit vague as it is doing more than just dedup.
could you please extend it a bit more? thanks

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Mar 29, 2026

Oh sorry. I excluded assert from release binary. Should I split the PR, or fix commit message?

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

GNU test failed: tests/misc/io-errors. tests/misc/io-errors is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/basenc/bounded-memory is now passing!
Congrats! The gnu test tests/unexpand/bounded-memory is now passing!
Skip an intermittent issue tests/pr/bounded-memory (was skipped on 'main', now failing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants