Fix Intermittent tests/date/date-locale-hour.sh#11497
Open
sylvestre wants to merge 2 commits intouutils:mainfrom
Open
Fix Intermittent tests/date/date-locale-hour.sh#11497sylvestre wants to merge 2 commits intouutils:mainfrom
sylvestre wants to merge 2 commits intouutils:mainfrom
Conversation
Fixes intermittent: tests/date/date-locale-hour.sh The GNU test date-locale-hour.sh picks 10 random locales via `locale -a | shuf -n 10`. In CI, zh_CN.GB18030 is installed and its date_fmt contains Chinese characters (年, 月, 日) encoded in GB18030, which is not valid UTF-8.
|
GNU testsuite comparison: |
Merging this PR will degrade performance by 4.63%
Performance Changes
Comparing 
Footnotes
|
cakebaker
reviewed
Mar 26, 2026
|
|
||
| let format = if let Some(form) = matches.get_one::<String>(OPT_FORMAT) { | ||
| let format = if let Some(form) = matches.get_one::<OsString>(OPT_FORMAT) { | ||
| let form = form.to_string_lossy(); |
Contributor
There was a problem hiding this comment.
I think this is not correct because GNU date doesn't use a lossy string:
$ cargo run -q date -d 2025-10-11T13:00 $'+\xFF%m' | hexdump -C
00000000 ef bf bd 31 30 0a |...10.|
00000006
$ date -d 2025-10-11T13:00 $'+\xFF%m' | hexdump -C
00000000 ff 31 30 0a |.10.|
00000004
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.