Skip to content

coreutils: strip errno#11484

Open
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:core-import
Open

coreutils: strip errno#11484
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:core-import

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented Mar 25, 2026

strip (os error N) from --version >/dev/full, etc...

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

GNU test failed: tests/misc/io-errors. tests/misc/io-errors is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/cp/link-heap is now being skipped but was previously passing.
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.

@oech3 oech3 marked this pull request as ready for review March 25, 2026 08:51
Copy link
Copy Markdown
Contributor

@xtqqczze xtqqczze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In future, could you minimise the diff by avoiding making unnecessary changes to type qualification.

@xtqqczze
Copy link
Copy Markdown
Contributor

These changes make error messages more consistent with GNU coreutils.

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Mar 25, 2026

Targets of diff are mostly same lines

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Mar 25, 2026

GNU's test suite stated extracting OS provided err messages and use it. So many tests might fail in the future by (os error N).

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cp/link-heap is now passing!
Note: The gnu test tests/misc/write-errors was skipped on 'main' but is now failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants