cksum: Use clap's usize parser and default_value("0") #11478
cksum: Use clap's usize parser and default_value("0") #11478baa-ableton wants to merge 1 commit intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
Merging this PR will degrade performance by 5.33%
Performance Changes
Comparing Footnotes
|
|
Still many Some() are kept. |
b2fa7df to
82a69c4
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
86a8a74 to
9625a26
Compare
|
Hey i think we can do another review. I'm a bit new to this so I could use a rather verbose review. Just wanna touch on the Some()s: |
|
GNU testsuite comparison: |
Signed-off-by: Babur Ayanlar <babur.ayanlar@ableton.com>
9625a26 to
ec152e4
Compare
|
Is |
|
GNU testsuite comparison: |
|
Strange... It increased RAM usage even Some() was removed. |
|
Doing this breaks GNU compatibility wrt error printing when the parsing of I am neither for or against doing so. I can hear that our GNU compatibility goal ends at error messages' formatting. In the current state, this PR both reduces performances (even so slightly) and reduces GNU compatibility, so I'm not particularly favorable to merge it. |
Closes: #11315