Conversation
|
do we need that many tests ? thanks |
|
Every test is a different edge case around the chunking process. I thought rather have a few more than a few too little. |
|
GNU testsuite comparison: |
|
yeah my point was that there is some duplications in the tests and they might be merged with a loop with different args / expectations |
Merging this PR will improve performance by 58.43%
Performance Changes
Comparing Footnotes
|
| #[allow(clippy::cognitive_complexity)] | ||
| fn unexpand_line( | ||
| buf: &mut Vec<u8>, | ||
| #[allow(clippy::too_many_arguments)] |
There was a problem hiding this comment.
for a different PR but it should be refactored
way too many arguments now
sylvestre
left a comment
There was a problem hiding this comment.
still waiting for some of the tests content to be deduplicated
New PR to fix issues after revert of #10798
Fix: #10698