Skip to content

Conversation

@w007878
Copy link
Contributor

@w007878 w007878 commented Jan 19, 2026

resolves #10318

Now the behavior aligned with GNU coreutils

$ ./uutils/mkfifo -m 4999 testfifo
mkfifo: invalid mode: invalid digit found in string
$ ./uutils/mkfifo -m 4777 testfifo
mkfifo: mode must specify only file permission bits

GNU:

$ ./gnu/mkfifo -m 4999 testfifo
mkfifo: invalid mode
$ ./gnu/mkfifo -m 4777 testfifo
mkfifo: mode must specify only file permission bits

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 19, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing w007878:fix/mkfifo (0b7d547) with main (00f77cc)

Summary

✅ 142 untouched benchmarks
⏩ 180 skipped benchmarks1

Footnotes

  1. 180 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/follow-name (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/dd/stderr is no longer failing!
Congrats! The gnu test tests/tac/tac-2-nonseekable is no longer failing!
Congrats! The gnu test tests/tail/follow-stdin is no longer failing!

@w007878 w007878 marked this pull request as draft January 20, 2026 15:24
Co-authored-by: Chris Dryden <christopher.paul.dryden@gmail.com>
@w007878 w007878 marked this pull request as ready for review January 21, 2026 04:12
@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/misc/unexpand is no longer failing!

@sylvestre sylvestre merged commit 3026d0d into uutils:main Jan 21, 2026
132 of 133 checks passed
mattsu2020 pushed a commit to mattsu2020/coreutils that referenced this pull request Jan 23, 2026
---------

Co-authored-by: Chris Dryden <christopher.paul.dryden@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mkfifo does not reject special permission bits in mode argument

3 participants