Skip to content

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Jan 19, 2026

Closes #5797 since #10347 was reported.

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 19, 2026

CodSpeed Performance Report

Merging this PR will degrade performance by 14.71%

Comparing oech3:patch-8 (18a7cd7) with main (8d02762)

Summary

⚡ 6 improved benchmarks
❌ 1 regressed benchmark
✅ 275 untouched benchmarks
⏩ 38 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory sort_long_line[160000] 732.3 KB 858.6 KB -14.71%
Memory sort_mixed_data[500000] 25.8 MB 22.4 MB +15.24%
Memory sort_accented_data[500000] 25.5 MB 21.6 MB +18.11%
Memory sort_key_field[500000] 31.4 MB 29.2 MB +7.53%
Memory sort_unique_locale[500000] 36.9 MB 33 MB +11.82%
Memory sort_ascii_only[500000] 25.5 MB 21.9 MB +16.74%
Memory du_wide_tree[(5000, 500)] 1.3 MB 1.2 MB +3.28%

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@sylvestre
Copy link
Contributor

why comment and not remove ? :)

I don't think sccache is used in this case as the build is done in a VM

@oech3
Copy link
Contributor Author

oech3 commented Jan 19, 2026

I'm OK to completely remove. But someone saw comments might try to send by rsync.

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

@cakebaker cakebaker merged commit 805390d into uutils:main Jan 22, 2026
155 of 157 checks passed
@cakebaker
Copy link
Contributor

Thanks!

@oech3 oech3 deleted the patch-8 branch January 22, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Useless GH actions for cache in FreeBSD workflow

3 participants