Skip to content

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Jan 15, 2026

Accept ginstall. Actually closes #9237

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 15, 2026

Merging this PR will degrade performance by 7.35%

⚡ 1 improved benchmark
❌ 2 regressed benchmarks
✅ 279 untouched benchmarks
⏩ 38 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory sort_ascii_utf8_locale 6.2 MB 6.7 MB -7.35%
Memory du_wide_tree[(5000, 500)] 1.2 MB 1.3 MB -3.3%
Memory du_deep_tree[(100, 3)] 155.8 KB 143.7 KB +8.41%

Comparing oech3:core-freepfx (ee3163a) with main (5fd3459)

Open in CodSpeed

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3
Copy link
Contributor Author

oech3 commented Jan 16, 2026

Is performance regression real?

@sylvestre
Copy link
Contributor

Nope. I think we have instabilities with these tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

coreutils: PROG_PREFIX needs -, =, or _

2 participants