Skip to content

Conversation

@trypsynth
Copy link

No description provided.

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

@cakebaker
Copy link
Contributor

Can you please add a test to ensure we don't regress in the future? Thanks.

@trypsynth
Copy link
Author

@cakebaker all done

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 15, 2026

Merging this PR will degrade performance by 27.39%

❌ 9 regressed benchmarks
✅ 273 untouched benchmarks
⏩ 38 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory cp_large_file[16] 115.3 KB 119.8 KB -3.76%
Memory sort_unique_locale[500000] 33.6 MB 39.8 MB -15.51%
Memory sort_ascii_only[500000] 22.2 MB 28.3 MB -21.77%
Memory sort_long_line[160000] 712.6 KB 981.4 KB -27.39%
Memory sort_key_field[500000] 47.8 MB 51.8 MB -7.62%
Memory sort_mixed_data[500000] 22.9 MB 27.1 MB -15.71%
Memory sort_numeric[500000] 75.5 MB 79.2 MB -4.67%
Memory sort_ascii_utf8_locale 6.2 MB 6.7 MB -7.35%
Memory sort_accented_data[500000] 22.1 MB 28.3 MB -21.79%

Comparing trypsynth:tail-zero (66a1944) with main (a1545ef)

Open in CodSpeed

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.


use crate::forwards_thru_file;
use std::io::Cursor;
use crate::{backwards_thru_file, forwards_thru_file};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be an integration test in test_tail.rs? I think it would be more ideal to make sure the behaviour with that specific command doesn't regress, also would have less boilerplate to set up the test conditions

@trypsynth
Copy link
Author

@ChrisDryden Done

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants