-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fixed passing -0 to tail. Closes #10191 #10209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
GNU testsuite comparison: |
|
Can you please add a test to ensure we don't regress in the future? Thanks. |
|
@cakebaker all done |
Merging this PR will degrade performance by 27.39%
Performance Changes
Comparing Footnotes
|
src/uu/tail/src/tail.rs
Outdated
|
|
||
| use crate::forwards_thru_file; | ||
| use std::io::Cursor; | ||
| use crate::{backwards_thru_file, forwards_thru_file}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be an integration test in test_tail.rs? I think it would be more ideal to make sure the behaviour with that specific command doesn't regress, also would have less boilerplate to set up the test conditions
|
@ChrisDryden Done |
|
GNU testsuite comparison: |
No description provided.