Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,8 @@ unused_qualifications = "warn"
all = { level = "warn", priority = -1 }
cargo = { level = "warn", priority = -1 }
pedantic = { level = "warn", priority = -1 }
print_stdout = "warn" # restriction: forbid print/println macros
print_stderr = "warn" # restriction: forbid eprint/eprintln macros
use_self = "warn" # nursery lint
cargo_common_metadata = "allow" # 3240
multiple_crate_versions = "allow" # 2882
Expand Down
7 changes: 6 additions & 1 deletion src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ mod cli;
mod utils;

use std::env::args_os;
use std::io::{self, Write};

use bumpalo::Bump;
use clap::Parser as _;
Expand Down Expand Up @@ -45,7 +46,11 @@ fn uu_main() -> Result<()> {
return Ok(());
}
};
println!("---\n{ast}");
if let Err(e) = writeln!(io::stdout(), "---\n{ast}")
&& e.kind() != io::ErrorKind::BrokenPipe
{
exit_err(Some(format!("awk: error writing to standard output: {e}")));
}
dbg!(arena.chunk_capacity());

// for token in lex {
Expand Down
3 changes: 2 additions & 1 deletion src/utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
// files that was distributed with this source code.

use std::fmt::{Debug, Display};
use std::io::{self, Write};
use std::panic::{UnwindSafe, catch_unwind, set_hook, take_hook};
use std::process::exit;

Expand Down Expand Up @@ -73,7 +74,7 @@ pub fn exit_with(res: Result<Option<impl Into<ExitCode>>, impl Display + Debug>)

pub fn exit_err(err: Option<impl Display + Debug>) -> ! {
if let Some(err) = err {
eprintln!("{err}");
let _ = writeln!(io::stderr(), "{err}");
}
exit(EXIT_FAILURE)
}
26 changes: 26 additions & 0 deletions tests/by-util/test_awk.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,29 @@ fn print_first_field() {
fn no_args_fails_code_one() {
ucmd().fails_with_code(1);
}

// Regression test for issue #5: writing to /dev/full must not panic.
#[cfg(target_os = "linux")]
#[test]
fn write_to_dev_full_does_not_panic() {
use std::fs::OpenOptions;
use std::process::{Command, Stdio};

let dev_full = match OpenOptions::new().write(true).open("/dev/full") {
Ok(f) => f,
Err(_) => return, // /dev/full not available; skip.
};
let output = Command::new(super::TESTS_BINARY)
.arg("BEGIN { print 1 }")
.stdout(Stdio::from(dev_full))
.stderr(Stdio::piped())
.output()
.expect("failed to spawn awk");
// Must not panic (panic exits with code 2).
assert_ne!(output.status.code(), Some(2));
let stderr = String::from_utf8_lossy(&output.stderr);
assert!(
!stderr.contains("panicked"),
"awk panicked on write to /dev/full: stderr={stderr}"
);
}