fix(lib): restore automatic hashtag creation for unknown tags #673
+440
−35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
useTags.tsxthat preventedaddTagfrom accessing current stateuseEffectinPopupView.tsxto persist newly detected hashtags to the databaseProblem
Hashtags in item text that didn't exist in the database were not being automatically created. For example,
#networkingwould appear as plain black text instead of being recognized as a hashtag with a color.Root Causes
1. Stale Closure in
addTag(useTags.tsx)The
addTagfunction usedtagsandapifrom the closure scope, which were stale when the function was called:2. Missing Persistence (PopupView.tsx)
New tags were detected and collected in
newTagsToAddstate, but never actually persisted:Solution
useTags.tsx
useRefforapiRefandtagsRefto always access current valuesaddTaginuseCallbackwith empty dependenciesPopupView.tsx
useAddTaghookuseEffectthat callsaddTagfor each new tag whennewTagsToAddchangesTest plan
#testnewtag)🤖 Generated with Claude Code