perf(pm): cap install tarball downloads#2987
Draft
elrrrrrrr wants to merge 1 commit into
Draft
Conversation
elrrrrrrr
added
A-Pkg Manager
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a dedicated download_concurrency_limit function in install_scheduler.rs to manage download limits, replacing an inline calculation. The new function ensures the limit is clamped between 1 and 128. I have no feedback to provide as there were no review comments.
📊 pm-bench-phases ·
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #2986. This AB experiment caps install tarball download concurrency independently from manifest concurrency.
Hypothesis
The install scheduler currently reuses manifest concurrency for tarball downloads. In p3, tarball downloads are followed by extract-to-cache and clone/materialize work, so excessive download fan-out can increase IO pressure and scheduler churn without improving end-to-end wall time. A lower tarball cap may keep the pipeline saturated while reducing contention.
Validation
cargo fmtCARGO_NET_OFFLINE=true cargo clippy -p utoo-pm --all-targets -- -D warnings --no-depsCARGO_NET_OFFLINE=true cargo test -p utoo-pm service::install_scheduler -- --nocapture