apple: use public availability checks for dynamic resolution #7572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use macOS 14+ availability checks for dynamic resolution support and simplify resolution restore from polling loop to single delayed call. Changes: - Remove supportsReconfiguration computed property - Replace checks with #available(macOS 14, *) - Simplify resolution restore timing
Contributor
|
Can you explain what you are trying to achieve here? The reason the logic is so complex is because we have different combinations of: macOS guest (below 14 and at least 14), Linux guests, and macOS hosts (below 14 and at least 14). Only specific combinations work hence the complicated logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details
This updates the dynamic resolution implementation to use the public
automaticallyReconfiguresDisplayAPI onVZVirtualMachineView(macOS 14+).Changes:
supportsReconfigurationcomputed property#available(macOS 14, *)