Fix header section offset when a note has properties#11
Conversation
|
Thank you for adding the esbuild and package.json -- this was super useful for developing my PR too.! Maybe consider separating esbuild+package.json into it's own PR, in order to separate the concerns and keep each PR atomic? |
|
Thank you for the PR! The build tool additions ( However, I'd like to hold off on the logic changes for now: Regarding the properties/offset fix: Regarding "Load all embeds instantly": It would conceptually look something like this: const processQueue = async (embeds) => {
for (const embed of embeds) {
await this.loadEmbed(embed);
await new Promise(r => setTimeout(r, 50)); // Tiny breather for the main thread
}
};Next Steps: I’d love to merge the build system modernization immediately. We can then tackle the staggered loading feature in a separate PR. Let me know! |
|
Hey, sorry for the late reply, I noticed you already made some changes for the esbuild and package.json, do you still need these changes in these PR? I can remove some of my changes that are conflicting with the new esbuild and package.json, Regarding the properties/offset fix, I noticed the same thing too recently, I can remove those changes from this PR. Regarding the Load all embeds instantly, using staggered loading definitely makes sense to me, I can add that as a change. I added that as a feature for my own use case, because when I was running the plugin on mobile, I would run into issues with laggy behavior when I would scroll through a note quickly. Using staggered loading should still fix those issues and help with performance at the same time. |
|
No worries at all, and thanks for checking in. Yeah, that sounds good to me. Let’s just move forward with the staggered loading for this PR. I agree it feels like the right balance. It should help with the mobile lag, I noticed this too, and it looks like you’ve already got it working nicely. Appreciate you taking the time to adjust things. |
Changes
I also made some changes on the styling and padding, padding is a little too thick for my taste. Might be good to add a toggle in the settings for that