SST1RSoXSDB metadata change: make loadMonitors handle scans without monitors
#215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #214 which was caused by a change in instrument metadata.
In brief, at some point the instrument stopped saving monitor data as streaming monitors. This hit a strange cut-out in
loadMonitorsthat just returned an empty xarray if there were no streams explicitly named "monitor". This PR changes that cut-out to just pass back the same xarray.It also adds a skeleton of support for double-diode I0 normalization with a new class variable for a perfectly matching scan id. It's primitive, but a start. Other features in other branches - most notably
findAppropriateDiodesForScanin #137 - will make this a lot better, but they need to be reviewed cough@KSRandazzo, could you take a look at this PR?