Skip to content

fix: Resolve status 10 error due to command order when active option is enabled #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ushiboy merged 1 commit into from
Dec 14, 2025
Merged

fix: Resolve status 10 error due to command order when active option is enabled #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions nmcli/_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,12 @@ def down(self, name: str, wait: int = None) -> None:
self._syscmd.nmcli(cmd)

def show(self, name: str, show_secrets: bool = False, active: bool = False) -> ConnectionDetails:
cmd = ['connection', 'show', name]
if show_secrets:
cmd += ["--show-secrets"]
cmd = ['connection', 'show']
if active:
cmd += ["--active"]
cmd += [name]
if show_secrets:
cmd += ["--show-secrets"]
r = self._syscmd.nmcli(cmd)
results = {}
for row in r.split('\n'):
Expand Down
2 changes: 1 addition & 1 deletion tests/test_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ def test_show():

connection.show(name, active=True)
assert s.passed_parameters == [
'connection', 'show', name, "--active"]
'connection', 'show', "--active", name]


def test_reload():
Expand Down