M64_006: auth e2e continuation + W3 carry-over changelog#50
Merged
Conversation
useClientToken retired; eight dashboard lifecycles now covered by Playwright auth suite; auth-e2e-dev + auth-e2e-prod jobs gate every dev and prod deploy. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
AGENTS.md §Terminology lists `spec`, `run`, `runs`, `gate loop`, and
`scorecard` as forbidden — they reference a v1 product surface that
has been retired. Two bare-prose uses ("Five new specs land",
"tracked in spec Discovery") slipped into the M64_006 changelog.
Replaced with "test files" / "test Discovery". Playwright file paths
(`*.spec.ts`) are kept verbatim — those are real file names, not
product nouns. Greptile P2.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
AGENTS.md §Content boundaries: "Do not expose credential values, vault paths, or 1Password references." The auth-e2e bullets shipped the exact 1Password paths for both Clerk credential sets (`op://VAULT_DEV/clerk-dev/*` and `op://VAULT_PROD/clerk-prod/*`) on the public Mintlify site, revealing the vault + item structure to anyone browsing the changelog. Replaced with generic "project's dev/prod secret vault" phrasing. The env-var names (`CLERK_SECRET_KEY`, `CLERK_WEBHOOK_SECRET`) and workflow file paths stay — they're not secret. Greptile P1 / Security. Pre-existing leak at line 650 (`op://ZMB_CD_<env>/usezombie-admin/api_key` in a historical entry) is out of scope for this PR; flagged in the session report for a separate cleanup commit. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<Update label="May 11, 2026">entry on the changelog covers theuseClientTokenretirement, the eight unblocked Playwright authenticated specs, the<RadioGroup>primitive ship, the zombiectl coverage uplift, and theauth-e2e-dev+auth-e2e-prodCI jobs.Test plan
<Update>block above the existing May 11 entry.Internal,Testing,CI.**Bold lead-noun** — consequence-firstshape.🤖 Generated with Claude Code
Greptile Summary
This PR adds a new
<Update label="May 11, 2026">changelog entry documenting the M64_006 auth e2e continuation work:useClientTokenretirement, eight unblocked Playwright tests, the<RadioGroup>primitive ship,zombiectlcoverage uplift, and the two new CI jobs.useClientTokenretired — all six dashboard mutation routes now use per-route Server Actions via thewithToken<T>shared wrapper; the api-template JWT is never exposed to the browser.test.fixmespecs (lifecycle, kill, signup) and five new test files (multi-zombie, multi-workspace, settings-billing, events, logs-detail) now run in CI.auth-e2e-devandauth-e2e-prodjobs added to the dev deploy and post-prod smoke workflows respectively.Confidence Score: 5/5
Documentation-only changelog entry — no executable code changed, and the vault path exposure flagged in earlier review rounds is no longer present in the current diff.
The change is a single MDX block describing already-shipped work. The previously raised vault-path exposure (op:// references) has been addressed; what remains are minor terminology nits against the AGENTS.md style guide.
No files require special attention beyond the terminology note on changelog.mdx.
Important Files Changed
Sequence Diagram
sequenceDiagram participant Browser participant SA as Server Action<br/>(per-route actions.ts) participant WT as withToken wrapper<br/>(lib/actions/with-token.ts) participant API as API backend<br/>(api-dev / api.usezombie.com) Note over Browser,API: Before M64_006 - client-side token fetch Browser->>Browser: fetch token client-side Browser->>API: mutation request with token Note over Browser,API: After M64_006 - server-side token mint Browser->>SA: invoke mutation SA->>WT: withToken(handler) WT->>API: server mints token, calls API API-->>WT: response WT-->>SA: ActionResult of T SA-->>Browser: ok plus data OR ok false plus errorPrompt To Fix All With AI
Reviews (2): Last reviewed commit: "docs(changelog): redact 1Password vault ..." | Re-trigger Greptile
Context used: