Skip to content

Maintenance and fixes and additions on vis::Graphs and its users#2769

Open
jurgenvinju wants to merge 4 commits intomainfrom
feat/dagre-edges-in-vis-graphs
Open

Maintenance and fixes and additions on vis::Graphs and its users#2769
jurgenvinju wants to merge 4 commits intomainfrom
feat/dagre-edges-in-vis-graphs

Conversation

@jurgenvinju
Copy link
Copy Markdown
Member

  • improvements to the general graph framework
  • do not overwrite dagre defaults with our own
  • cleanup

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46%. Comparing base (8ae6ced) to head (022df26).

Additional details and impacted files
@@           Coverage Diff           @@
##              main   #2769   +/-   ##
=======================================
- Coverage       46%     46%   -1%     
  Complexity    6726    6726           
=======================================
  Files          794     794           
  Lines        65936   65936           
  Branches      9888    9888           
=======================================
- Hits         30856   30852    -4     
- Misses       32690   32700   +10     
+ Partials      2390    2384    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@DavyLandman DavyLandman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, my main concern is the inclusion of the cytoscape-dagre.js file in the repo.

@@ -0,0 +1,550 @@
(function webpackUniversalModuleDefinition(root, factory) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we now ship the cytoscape file? It's a bit suprising to me that a fix PR changes how we run cytoscape.

I mean, I would not mind if we don't have this online dependency in our graph code, but then there are some cleaner ways to package this (like part of a maven phase that automatically downloads dependencies from npm).

Also, what is the license of this external file?

Looks like this PR should wait for cytoscape/cytoscape.js-dagre#163 to get merged and released? (which could be soon it looks like it)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I expect the merge to take several weeks.
  2. I had issues running this code without a network. The online dependency sucks, however that also goes for the entire cytoscape.js library. I wasn't ready to make that decision yet, but this cytoscape-dagre.js code is now more lines of us than the original so I felt safe to copy it in.
  3. I don't know what the wise decision is here. It's a trade-of. But for now we can include it and test it locally. When cytoscape.js-dagre is released we have a choice to make.

Comment thread src/org/rascalmpl/library/vis/Graphs.rsc
Comment thread src/org/rascalmpl/library/vis/Graphs.rsc
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 6, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants