Open
Conversation
… into fix/breaking-compiler-test-2710
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2726 +/- ##
========================================
- Coverage 46% 46% -1%
- Complexity 6677 6679 +2
========================================
Files 795 796 +1
Lines 65916 66046 +130
Branches 9883 9900 +17
========================================
+ Hits 30706 30718 +12
- Misses 32821 32944 +123
+ Partials 2389 2384 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This set of changes, that only change where the test suite is storing their test seems to break the typechecker on a predicatble path.
Current hypothesis is that it's related to import caching. As a re-import of the affected module
lang::rascalcore::check::tests::FunctionTCTestsfixes the bug.The biggest file is a runner that runs the test in parallel to see if we can break it, and this module and the
BoundOK1keeps failing.Note it contains commits from #2713 but that was splitup into this one and #2725