No longer wrapping complex types in an auxiliary JSON object #2599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2599 +/- ##
========================================
Coverage 46% 46%
- Complexity 6637 6652 +15
========================================
Files 793 793
Lines 65695 65697 +2
Branches 9840 9839 -1
========================================
+ Hits 30500 30618 +118
+ Misses 32835 32720 -115
+ Partials 2360 2359 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…JSON (de)serialization
The test for `set`s is currently failing
The test for `rat`s is currently failing
The test for `rat`s and all non-primitive values are currently failing
The test for `rat`s is currently failing
rodinaarssen
force-pushed
the
fix-jsonrpc-wrapping
branch
from
a4564b5 to
3e22617
Compare
Member
|
Looks good, but please update the pom.xml config to make sure these tests are run during CI. |
…string. On the deserialization site, this was already available
DavyLandman
requested changes
Jan 21, 2026
Member
DavyLandman
left a comment
DavyLandman
left a comment
There was a problem hiding this comment.
I think the test need a bit more love
src/org/rascalmpl/library/lang/rascal/tests/library/lang/json/JSONIOTests.rsc
Show resolved
Hide resolved
DavyLandman
requested changes
Jan 22, 2026
Member
DavyLandman
left a comment
DavyLandman
left a comment
There was a problem hiding this comment.
a few small nits and only one remaining thing, after that, ready to merge I would say
…cal definition" This reverts commit b861ec5.
DavyLandman
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complex types were wrapped in an auxiliary object to avoid ambiguities between the JSON representation of containers and "lists as a sole argument" on the JSON-RPC level. This is not necessary, as complex types are not automatically deserializable through this path anyway. This PR removes wrapping around complex types, leaving rationals as the only values that are wrapped when encoding values as JSON objects.
FIxes usethesource/rascal-language-servers#944