Fixed a compile warning into the periodic_task.#1150
Closed
proydakov wants to merge 1 commit intouserver-framework:developfrom
Closed
Fixed a compile warning into the periodic_task.#1150proydakov wants to merge 1 commit intouserver-framework:developfrom
proydakov wants to merge 1 commit intouserver-framework:developfrom
Conversation
[1848/2256] Building CXX object core/CMakeFiles/userver-core.dir/src/utils/periodic_task.cpp.o
/home/proydakov/repository/userver/core/src/utils/periodic_task.cpp: In function ‘void userver::v2_16_rc::utils::StartPeriodicTask(PeriodicTask&, std::string, const PeriodicTask::Settings&, PeriodicTask::Callback, userver::v2_16_rc::testsuite::TestsuiteTasks&)’:
/home/proydakov/repository/userver/core/src/utils/periodic_task.cpp:328:55: warning: redundant move in initialization [-Wredundant-move]
328 | periodic_task.Start(std::move(name), std::move(settings), std::move(callback));
| ~~~~~~~~~^~~~~~~~~~
/home/proydakov/repository/userver/core/src/utils/periodic_task.cpp:328:55: note: remove ‘std::move’ call
At global scope:
Signed-off-by: Evgeny Proydakov <e.proydakov@gmail.com>
Member
|
LGTM |
|
Many thanks for the PR! @apolukhin is now importing your pull request into our internal upstream repository. |
|
✅ This pull request is being closed because it has been successfully merged into our internal monorepository. |
robot-piglet
pushed a commit
that referenced
this pull request
Mar 23, 2026
```
[1848/2256] Building CXX object core/CMakeFiles/userver-core.dir/src/utils/periodic_task.cpp.o /home/proydakov/repository/userver/core/src/utils/periodic_task.cpp: In function ‘void userver::v2_16_rc::utils::StartPeriodicTask(PeriodicTask&, std::string, const PeriodicTask::Settings&, PeriodicTask::Callback, userver::v2_16_rc::testsuite::TestsuiteTasks&)’: /home/proydakov/repository/userver/core/src/utils/periodic_task.cpp:328:55: warning: redundant move in initialization [-Wredundant-move]
328 | periodic_task.Start(std::move(name), std::move(settings), std::move(callback));
| ~~~~~~~~~^~~~~~~~~~
/home/proydakov/repository/userver/core/src/utils/periodic_task.cpp:328:55: note: remove ‘std::move’ call
At global scope:
```
---
Pull Request resolved: #1150
commit_hash:cabd28df492569e029f334ea1e18da41d5f45b57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, @apolukhin.
Could you review and accept my change, pls?
[1848/2256] Building CXX object core/CMakeFiles/userver-core.dir/src/utils/periodic_task.cpp.o /home/proydakov/repository/userver/core/src/utils/periodic_task.cpp: In function ‘void userver::v2_16_rc::utils::StartPeriodicTask(PeriodicTask&, std::string, const PeriodicTask::Settings&, PeriodicTask::Callback, userver::v2_16_rc::testsuite::TestsuiteTasks&)’: /home/proydakov/repository/userver/core/src/utils/periodic_task.cpp:328:55: warning: redundant move in initialization [-Wredundant-move]
328 | periodic_task.Start(std::move(name), std::move(settings), std::move(callback));
| ~~~~~~~~~^~~~~~~~~~
/home/proydakov/repository/userver/core/src/utils/periodic_task.cpp:328:55: note: remove ‘std::move’ call
At global scope:
Best regards, Evgeny Proydakov.
Note: by creating a PR or an issue you automatically agree to the CLA. See CONTRIBUTING.md. Feel free to remove this note, the agreement holds.