Skip to content

Cleanup and fix workflows for adding git trailers v2#646

Merged
urunc-bot[bot] merged 1 commit into
mainfrom
fix_trailers
May 8, 2026
Merged

Cleanup and fix workflows for adding git trailers v2#646
urunc-bot[bot] merged 1 commit into
mainfrom
fix_trailers

Conversation

@cmainas
Copy link
Copy Markdown
Contributor

@cmainas cmainas commented May 8, 2026

Description

Clean up the workflows that add git trailers after an approval of a review. In particular:

  • remove duplicate step for adding git trailers,
  • remove setting up git
  • update the reusable action to use a branch of main that accounts for forked contributions.

Related issues

How was this tested?

In a forked repository.

LLM usage

Assisted by Opus 4.6 through Copilot.

Checklist

  • I have read the contribution guide.
  • The linter passes locally (make lint).
  • The e2e tests of at least one tool pass locally (make test_ctr, make test_nerdctl, make test_docker, make test_crictl).
  • If LLMs were used: I have read the llm policy.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 8, 2026

Deploy Preview for urunc canceled.

Name Link
🔨 Latest commit 89a3ea5
🔍 Latest deploy log https://app.netlify.com/projects/urunc/deploys/69fde2bfba895200080b28fb

@cmainas cmainas marked this pull request as ready for review May 8, 2026 13:09
@cmainas cmainas requested a review from ananos May 8, 2026 13:09
Clean up the workflows that add git trailers after an approval of a
review. In particular:
- remove duplicate step for adding git trailers,
- remove step for setting up git,
- use a branch from the git-trailers main which accounts for external
  contributors too

PR: #646
Signed-off-by: Charalampos Mainas <charalampos.mainas@gmail.com>
Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk>
Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
@urunc-bot urunc-bot Bot merged commit b873cc4 into main May 8, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The action to add git trailers fails for users with multiple names

2 participants