refactor(e2e): deduplicate DescribeTable bodies across tools#537
Open
IrvingMg wants to merge 1 commit intourunc-dev:mainfrom
Open
refactor(e2e): deduplicate DescribeTable bodies across tools#537IrvingMg wants to merge 1 commit intourunc-dev:mainfrom
IrvingMg wants to merge 1 commit intourunc-dev:mainfrom
Conversation
Signed-off-by: Irving Mondragón <mirvingr@gmail.com>
✅ Deploy Preview for urunc canceled.
|
Contributor
Author
|
@cmainas Since this PR closes the Ginkgo migration issue, should I update the description to also close these two related issues? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #527 (review), this cleanup commonizes the e2e tests logic.
Related issues
Since this is the last PR for the migration of e2e tests to Ginkgo
How was this tested?
LLM usage
N/A
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).