Fix tests and prevent errors when removing the map#527
Open
josh-cloudscape wants to merge 2 commits intourbica:mainfrom
Open
Fix tests and prevent errors when removing the map#527josh-cloudscape wants to merge 2 commits intourbica:mainfrom
josh-cloudscape wants to merge 2 commits intourbica:mainfrom
Conversation
This fixes the tests that were failing. It looks like @deck.gl uses
dependencies that were converted to esm modules and jest isn't currently
set up to handle them.
```
Jest encountered an unexpected token
...
/home/runner/work/react-map-gl/react-map-gl/node_modules/@deck.gl/layers/node_modules/@mapbox/tiny-sdf/index.js:3
export default class TinySDF {
^^^^^^
SyntaxError: Unexpected token 'export'
```
Reference: visgl/deck.gl#7735
Prevents errors when unmounting the map while images are still loading.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #527 +/- ##
==========================================
- Coverage 97.96% 97.72% -0.25%
==========================================
Files 28 28
Lines 738 746 +8
Branches 189 191 +2
==========================================
+ Hits 723 729 +6
- Misses 11 13 +2
Partials 4 4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore(deps): revert @deck.gl/layers to 8.8.9
This fixes the tests that were failing. It looks like @deck.gl uses dependencies that were converted to esm modules and jest isn't currently set up to handle them.
Reference: visgl/deck.gl#7735
fix(image): don't add images if map or component is unloaded
Prevents errors when unmounting the map while images are still loading.