Open
Conversation
215fc69 to
82e86fc
Compare
f888490 to
ba8fc2d
Compare
Member
Author
|
Hello @pkieltyka, What do you think about moving tests to a directory? |
Member
|
Neat to see some clean up here :) By putting into internal folder, does that change go.mod behaviour I wonder? Looks good either way though |
Member
Author
|
I think it doesn’t because they’re only tests. But that’s important and it's worth a try.
…On Wed 19 Feb 2020 at 7:25 Peter Kieltyka ***@***.***> wrote:
Neat to see some clean up here :) By putting into internal folder, does
that change go.mod behaviour I wonder? Looks good either way though
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#34?email_source=notifications&email_token=AAC6FBXEE3Q4REQQRSPGJYLRDUXLJA5CNFSM4KXNLBKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMH2JII#issuecomment-588227745>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC6FBRWN6Y4UPC4ZSWORL3RDUXLJANCNFSM4KXNLBKA>
.
|
Member
Author
|
I tried this out with https://github.com/upper/bond-example-project and didn't find anything odd with the directory change. I simulated a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal/tests