Skip to content

Memoize toggle function #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Velenir wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Memoize toggle function #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useState, useEffect, useRef } from 'react';
import React, { useState, useEffect, useRef, useCallback } from 'react';
import ReactDOM from 'react-dom';
import PropTypes from 'prop-types';
import classNames from 'classnames';
Expand Down Expand Up @@ -140,14 +140,14 @@ export const useModali = (options) => {
isModalVisibleRef.current = isModalVisible;
let timeoutHack;

function toggle() {
const toggle = useCallback(() => {
timeoutHack = setTimeout(() => {
setIsModalVisible(!isModalVisibleRef.current);
clearTimeout(timeoutHack);
}, 10);
setIsShown(!isShown);
setIsShown(isShown => !isShown);
setHasToggledBefore(true);
}
}, [])

function handleKeyDown(event) {
if (event.keyCode !== 27 || (options && options.keyboardClose === false)) return;
Expand Down