Restore original BigNumber.DEBUG value after the asserts
#270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the BigNumber.DEBUG state management to ensure the original value is always restored after assertions complete, preventing side effects that could affect other code using BigNumber.
- Centralized
BigNumber.DEBUGstate management in the baseBigNumberAssertclass with proper cleanup - Removed redundant
BigNumber.DEBUGassignments from all comparison assert constructors - Added comprehensive test coverage for DEBUG restoration in success, validation failure, and constructor failure scenarios
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/asserts/big-number-assert.js | Implements DEBUG state preservation using try-finally pattern in the validate method |
| src/asserts/big-number-equal-to-assert.js | Removes redundant DEBUG assignment from constructor |
| src/asserts/big-number-greater-than-assert.js | Removes redundant DEBUG assignment from constructor |
| src/asserts/big-number-greater-than-or-equal-to-assert.js | Removes redundant DEBUG assignment from constructor |
| src/asserts/big-number-less-than-assert.js | Removes redundant DEBUG assignment from constructor |
| src/asserts/big-number-less-than-or-equal-to-assert.js | Removes redundant DEBUG assignment from constructor |
| test/asserts/big-number-assert.test.js | Adds tests verifying DEBUG restoration for successful and failed validations |
| test/asserts/big-number-equal-to-assert.test.js | Adds tests verifying DEBUG restoration across all validation scenarios |
| test/asserts/big-number-greater-than-assert.test.js | Adds tests verifying DEBUG restoration across all validation scenarios |
| test/asserts/big-number-greater-than-or-equal-to-assert.test.js | Adds tests verifying DEBUG restoration across all validation scenarios |
| test/asserts/big-number-less-than-assert.test.js | Adds tests verifying DEBUG restoration across all validation scenarios |
| test/asserts/big-number-less-than-or-equal-to-assert.test.js | Adds tests verifying DEBUG restoration across all validation scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
goncalvesnelson
force-pushed
the
support/fix-bignumber-assert-debug-side-effect
branch
from
9ee906e to
bbadb0a
Compare
Americas
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the original
BigNumber.DEBUGvalue is restored after running any of the BigNumber asserts.