-
Notifications
You must be signed in to change notification settings - Fork 1
Add Tests workflow and replace Jest with node:test
#40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates testing from Jest to Node.js’s built-in node:test, adds a GitHub Actions workflow for tests and coverage, removes Jest and Travis CI config, updates package scripts and README badges, and bumps the minimum Node.js version to 20.
- Replace Jest with
node:testin all test files and introduce a sharedtest-http-errorutil. - Remove
jest.jsonand.travis.yml, updatepackage.jsonscripts, and add.github/tests.yamlworkflow. - Update README with new test instructions, status badges, and bump engines to Node.js ≥20.
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| test/utils/test-http-error.js | Updated to use node:test’s it and assert, replaced Jest API |
| test/errors/*_test.js | Replaced Jest imports with node:test and calls to testHttpError |
| package.json | Updated test scripts, removed Jest dependency, bumped Node engine |
| jest.json | Removed (no longer needed) |
| README.md | Added badges and updated test instructions |
| .travis.yml | Removed Travis CI config |
| .github/tests.yaml | Added GitHub Actions workflow for tests and coverage |
Comments suppressed due to low confidence (1)
test/utils/test-http-error.js:14
- Parameter
Errorshadows the global Error constructor. Consider renaming it toErrorClassorHttpErrorConstructorfor clarity.
module.exports = (Error, code, message, testArguments = true) => {
a8d6de7 to
7b5a858
Compare
- Remove `jest` - Update minimum Node.js version to 20 - Update `README.md` with NPM and Tests badges, and updated test instructions
7b5a858 to
524c9fd
Compare
Kamefrede
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
node:test.READMEwith new test instructions and status badges.