Skip to content

Conversation

@risantos
Copy link
Member

@risantos risantos commented Jun 2, 2025

Description

  • Add a Tests workflow using GitHub Actions.
  • Remove Jest in favor of Node.js built-in test module, node:test.
  • Update the README with new test instructions and status badges.
  • Minimum Node.js version is now set to 20.

Copilot AI review requested due to automatic review settings June 2, 2025 15:45
@risantos risantos added the dependencies Pull requests that update a dependency file label Jun 2, 2025
@risantos risantos self-assigned this Jun 2, 2025
@risantos risantos mentioned this pull request Jun 2, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates testing from Jest to Node.js’s built-in node:test, adds a GitHub Actions workflow for tests and coverage, removes Jest and Travis CI config, updates package scripts and README badges, and bumps the minimum Node.js version to 20.

  • Replace Jest with node:test in all test files and introduce a shared test-http-error util.
  • Remove jest.json and .travis.yml, update package.json scripts, and add .github/tests.yaml workflow.
  • Update README with new test instructions, status badges, and bump engines to Node.js ≥20.

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
test/utils/test-http-error.js Updated to use node:test’s it and assert, replaced Jest API
test/errors/*_test.js Replaced Jest imports with node:test and calls to testHttpError
package.json Updated test scripts, removed Jest dependency, bumped Node engine
jest.json Removed (no longer needed)
README.md Added badges and updated test instructions
.travis.yml Removed Travis CI config
.github/tests.yaml Added GitHub Actions workflow for tests and coverage
Comments suppressed due to low confidence (1)

test/utils/test-http-error.js:14

  • Parameter Error shadows the global Error constructor. Consider renaming it to ErrorClass or HttpErrorConstructor for clarity.
module.exports = (Error, code, message, testArguments = true) => {

@risantos risantos force-pushed the support/replace-jest branch from a8d6de7 to 7b5a858 Compare June 2, 2025 16:08
- Remove `jest`
- Update minimum Node.js version to 20
- Update `README.md` with NPM and Tests badges, and updated test instructions
@risantos risantos force-pushed the support/replace-jest branch from 7b5a858 to 524c9fd Compare June 4, 2025 10:42
Copy link
Member

@Kamefrede Kamefrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kamefrede Kamefrede merged commit 5420d99 into master Jun 4, 2025
3 checks passed
@risantos risantos deleted the support/replace-jest branch June 4, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants