Update documentation w.r.t. ignoreDefaultValue: true#2750
Update documentation w.r.t. ignoreDefaultValue: true#2750Vlatombe wants to merge 1 commit intoupdatecli:masterfrom
ignoreDefaultValue: true#2750Conversation
| * When used as a target, *only* the value of the argument (right of the `=` when present) | ||
| ** When no argument value is found (e.g. default value, no character `=` or empty value), | ||
| then updatecli appends the `=` character followed by the value. | ||
| then updatecli appends the `=` character followed by the value. It is possible to disable this behaviour by providing `ignoreDefaultValue: true` in the configuration. |
There was a problem hiding this comment.
Non-blocking: WDYT of ignoreNoArgValue, or (englobing ENV) ignoreUnspecifiedValue?
I find "default" a bit confusing and less immediate to understand. (personal opinion)
There was a problem hiding this comment.
I named the argument based on the existing documentation, which is IMO a bit confusing, since the official docker doc refers to "default" value as the literal value that may be specified. But we could also adjust the documentation to be more aligned with https://docs.docker.com/reference/dockerfile/#default-values.
Maybe ignoreMissingValue would make sense (I don't really like unspecified, too long).
There was a problem hiding this comment.
nit: "Missing" is a bit misleading as it's generally a choice of not specifying any value, not something missing (forgotten) per se.
To go along with the official docker doc, WDYT of ignoreNoDefaultValue or ignoreNoDefault (shorter)?
2 participants
updatecli/updatecli#7870
Fix #7841
Test
This project uses Netlify to generate preview environment,
so feel free to look there directly to see how this pullrequest render
Additional Information
Tradeoff
Potential improvement