Skip to content

Comments

Ported Led indicator service#47

Merged
Vortex148 merged 2 commits intouorocketry:feature/led-indicatorfrom
shayanbaig771:led-indicator
Feb 20, 2026
Merged

Ported Led indicator service#47
Vortex148 merged 2 commits intouorocketry:feature/led-indicatorfrom
shayanbaig771:led-indicator

Conversation

@shayanbaig771
Copy link
Contributor

@shayanbaig771 shayanbaig771 commented Feb 7, 2026

Hello,

This commit ports over the LedIndicatorService code from Argus to Phoenix. I didn't have access to the board schematics on Altium Workspace yet, so the pins might not be right. There's a cycle_leds() task provided too.

@Vortex148 Vortex148 self-requested a review February 20, 2026 21:23
Copy link
Contributor

@Vortex148 Vortex148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work! Next time, please do your changes in a separate branch not a forked repo (makes it easier for me to review) :)

@Vortex148 Vortex148 changed the base branch from main to feature/led-indicator February 20, 2026 21:34
@Vortex148
Copy link
Contributor

Moved target from main to feature branch

@Vortex148 Vortex148 merged commit a784cf6 into uorocketry:feature/led-indicator Feb 20, 2026
3 of 5 checks passed
Vortex148 added a commit that referenced this pull request Feb 20, 2026
* Ported Led indicator service (#47)

Co-authored-by: root <root@Shayans-ThinkPad>
Co-authored-by: Vortex148 <95885247+Vortex148@users.noreply.github.com>

Moved target from main to feature branch

* fix: Organize code for cargo fmt

---------

Co-authored-by: Shayan Baig <34322920+shayanbaig771@users.noreply.github.com>
@shayanbaig771
Copy link
Contributor Author

Will do!

Great Work! Next time, please do your changes in a separate branch not a forked repo (makes it easier for me to review) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants