-
Notifications
You must be signed in to change notification settings - Fork 28
docs: TabBar Styling Docs #1515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates TabBar documentation to clarify the correct styling pattern for Material Toolkit v2. The changes address confusion about how to apply styles to TabBar components by emphasizing that styles should be applied to the TabBar container rather than individual TabBarItem elements.
Key Changes:
- Updated code examples to demonstrate applying styles to TabBar containers (e.g.,
BottomTabBarStyle) instead of individual TabBarItem elements - Added IMPORTANT callout boxes explaining the Material Toolkit v2 styling pattern
- Clarified that
BottomTabBarItemStyleandVerticalTabBarItemStyleare internal implementation details that should not be referenced directly
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| doc/controls/walkthroughs/TabBar-and-TabBarItem.howto.md | Updated badge examples and added important note about applying styles to TabBar container instead of TabBarItem elements |
| doc/controls/TabBarAndTabBarItem.md | Added comprehensive IMPORTANT callout explaining the Material Toolkit v2 styling pattern, updated badge examples to follow the pattern, and clarified exception for BottomFabTabBarItemStyle |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
GitHub Issue (If applicable):
closes https://github.com/unoplatform/uno.ai-private/issues/500
closes https://github.com/unoplatform/uno.ai-private/issues/501
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements: