Skip to content

Conversation

@vatsashah45
Copy link
Contributor

@vatsashah45 vatsashah45 commented Dec 9, 2025

GitHub Issue (If applicable):
closes https://github.com/unoplatform/uno.ai-private/issues/500
closes https://github.com/unoplatform/uno.ai-private/issues/501

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Copilot AI review requested due to automatic review settings December 9, 2025 21:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates TabBar documentation to clarify the correct styling pattern for Material Toolkit v2. The changes address confusion about how to apply styles to TabBar components by emphasizing that styles should be applied to the TabBar container rather than individual TabBarItem elements.

Key Changes:

  • Updated code examples to demonstrate applying styles to TabBar containers (e.g., BottomTabBarStyle) instead of individual TabBarItem elements
  • Added IMPORTANT callout boxes explaining the Material Toolkit v2 styling pattern
  • Clarified that BottomTabBarItemStyle and VerticalTabBarItemStyle are internal implementation details that should not be referenced directly

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
doc/controls/walkthroughs/TabBar-and-TabBarItem.howto.md Updated badge examples and added important note about applying styles to TabBar container instead of TabBarItem elements
doc/controls/TabBarAndTabBarItem.md Added comprehensive IMPORTANT callout explaining the Material Toolkit v2 styling pattern, updated badge examples to follow the pattern, and clarified exception for BottomFabTabBarItemStyle

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vatsashah45 vatsashah45 self-assigned this Dec 9, 2025
@unodevops
Copy link
Contributor

⚠️⚠️ The build 187086 has failed on Uno Toolkit - CI.

@vatsashah45 vatsashah45 changed the title docs(TabBar): clarify Material v2 styling pattern docs: TabBar Styling Docs Dec 9, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kazo0 kazo0 enabled auto-merge (squash) December 9, 2025 21:52
@unodevops
Copy link
Contributor

⚠️⚠️ The build 187093 has failed on Uno Toolkit - CI.

@kazo0 kazo0 merged commit a80afa5 into main Dec 10, 2025
10 checks passed
@kazo0 kazo0 deleted the dev/vs/docs-tabbar branch December 10, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants