Skip to content

fix(docs): contrast on header links in dark/index #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NullVoxPopuli merged 1 commit into from
Feb 24, 2026
Merged

fix(docs): contrast on header links in dark/index #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions docs-app/src/components/header.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,25 @@
import { ExternalLink } from "ember-primitives";

import { GitHub } from "@universal-ember/docs-support/icons";
import type { TOC } from "@ember/component/template-only";

export const APIReferenceLink = <template>
<a
href="/api"
class="self-center text-sm font-medium text-slate-500 hover:text-slate-700 dark:text-slate-400 dark:hover:text-slate-200"
...attributes
>
API Reference
</a>
</template>;
</template> satisfies TOC<{ Element: HTMLAnchorElement }>;

export const GitHubLink = <template>
<ExternalLink
class="group"
class="group text-slate-400 hover:text-slate-500 dark:hover:text-slate-300"
href="https://github.com/universal-ember/table"
aria-label="GitHub"
...attributes
>
<GitHub
class="w-6 h-6 fill-slate-400 group-hover:fill-slate-500 dark:group-hover:fill-slate-300"
/>
<GitHub class="w-6 h-6 fill-current" />
</ExternalLink>
</template>;
</template> satisfies TOC<{ Element: HTMLAnchorElement }>;
6 changes: 4 additions & 2 deletions docs-app/src/templates/index.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,10 @@ import {
<IndexPage>
<:header>
<TopRight>
<GitHubLink />
<APIReferenceLink />
<GitHubLink class="!text-white hover:!text-slate-200" />
<APIReferenceLink
class="!text-white hover:!text-slate-200 dark:!text-white"
/>
</TopRight>
</:header>
<:tagline>
Expand Down
Loading