fix: expose missing public modifiers in Imperial units#213
Open
devhebert wants to merge 2 commits intounitsofmeasurement:masterfrom
Open
fix: expose missing public modifiers in Imperial units#213devhebert wants to merge 2 commits intounitsofmeasurement:masterfrom
devhebert wants to merge 2 commits intounitsofmeasurement:masterfrom
Conversation
keilw
requested changes
Mar 23, 2026
Member
keilw
left a comment
keilw
left a comment
There was a problem hiding this comment.
This likely affects unit tests, could you please check, they pass and add the necessary tests to this PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Imperial unit constants were declared with package-private
visibility, preventing external consumers from accessing them.
This change adds the missing
publicmodifier to the following units:These units are already fully defined and registered in the
SystemOfUnits, so exposing them does not change behavior,
only makes them accessible through the public API.
This change is