Enhance Telnet option handling and viewport management #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… listeners - Updated `TelnetOptionHandler` to include generic state management methods: `getState`, `onStateChange`, and `offStateChange`. - Refactored `handleEchoOption` to utilize a new `EchoNegotiator` class for managing echo state and event emissions. - Introduced `LinemodeNegotiator` class in `handle-linemode-option` to manage linemode state and subnegotiation. - Removed the `log-negotiation` utility and integrated logging directly into the `TelnetSocketWrapper`. - Added linemode state management in the frontend, allowing for dynamic updates based on server negotiations. - Created a new `LinemodeState` type to encapsulate linemode properties and updated the socket service to handle linemode events. - Updated frontend components to reflect changes in local echo behavior based on linemode state.
…formation and lifecycle management
mystiker
commented
Dec 20, 2025
frontend/src/app/features/sockets/types/server-to-client-events.ts
Outdated
Show resolved
Hide resolved
frontend/src/app/features/sockets/types/client-to-server-events.ts
Outdated
Show resolved
Hide resolved
- Introduced a new shared package for common types and utilities used across frontend and backend. - Added ServerConfig interface for backend configuration. - Defined ClientToServerEvents and ServerToClientEvents interfaces for Socket.IO communication. - Created LinemodeState interface to represent TELNET LINEMODE capabilities. - Implemented TypeScript configuration for the shared package. - Updated root package.json to include the shared workspace and adjusted build scripts.
myonara
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce state management for Telnet options, including linemode and echo handling.
Implement viewport size management in the backend and update frontend components to reflect these changes.
Additionally, streamline logging and improve socket message handling.