Avoid class template argument deduction (CTAD) to fix warnings#192
Merged
Conversation
grhoten
approved these changes
May 19, 2026
Member
grhoten
left a comment
grhoten
left a comment
There was a problem hiding this comment.
Definitely falls into the pedantic category.
Contributor
Author
Let's just say that all warnings are converted to errors in some places, pedantic or not :). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR avoids using Class Template Argument Deduction (CTAD) for
inflection::util::Finallyandinflection::dictionary::metadata::MarisaTrieby explicitly specifying template arguments or usingdecltypefor lambdas.Motivation
In some environments (e.g. with strict warning flags like
-Wctad-maybe-unsupportedenabled), using CTAD without explicit deduction guides can trigger compiler warnings or errors.Instead of adding deduction guides to the headers, this PR changes the local invocations to avoid deduction entirely, making the code more robust across different compiler configurations and avoiding the need for deduction guides.