ICU-23345 Require Range to be a range in UTFStringCodePoints to improve error messages#3733
Conversation
|
@markusicu, should this target main on a new ticket, or 78 maintenance on a reopened ICU-23004? |
@eggrobin is this PR fixing problems, or just "improv[ing] error messages"? @mihnita @richgillam FYI |
markusicu
left a comment
There was a problem hiding this comment.
lgtm as an improvement for ICU 79 -- please create an ICU 79 ticket for such improvements
markusicu
left a comment
There was a problem hiding this comment.
please create an ICU 79 ticket for this
|
This LGTM, but it involves newer C++ idioms that I'm not familiar with, so take everything I say with a grain of salt. |
markusicu
left a comment
There was a problem hiding this comment.
Is it possible to write a meaningful unit test for this?
If it doesn’t change the API, not within the language. It might be useful to set up a test harness that puts expectations on error messages, but not today. |
…ve error messages
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
|
FYI: CI checks finished & passed (and I approved last week) |
Suggested by @jmr after seeing the error messages generated by
UTFStringCodePoints<..., char>(which was how this API worked in an earlier draft).TODO: Fill out the checklist below.
Checklist