v2.17.2#752
Merged
julesghub merged 14 commits intounderworldcode:v2.17.xfrom May 5, 2026
Merged
Conversation
Change CHANGES.md to CHANGELOG.md
Moving `distinct_id` to the top level to capture stable users better
Port number was 8888, but should be 20000. Now fixed
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates Underworld2 to v2.17.2 while refreshing packaging/CI and developer container docs, plus some workflow automation cleanup.
Changes:
- Bump package version and raise minimum supported Python to 3.9.
- Update container/conda workflow references and dependency installation instructions.
- Remove the
actions/globalprotectGitHub Action and add a scheduled issue-metrics workflow.
Reviewed changes
Copilot reviewed 25 out of 27 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| src/underworld/_version.py | Bumps library version to 2.17.2 |
| src/underworld/init.py | Adjusts usage-metrics payload structure |
| pyproject.toml | Raises requires-python minimum to 3.9 |
| docs/development/release_guidelines.md | Updates release guideline reference from CHANGES to CHANGELOG |
| docs/development/gadi_singularity/underworld.rhel | Updates container build args and Badlands install approach |
| docs/development/gadi_singularity/README.md | Updates build arg name used in example command |
| docs/development/development_guidelines.md | Updates guideline reference from CHANGES to CHANGELOG |
| docs/development/container/README.md | Updates Containerfile path and documented Jupyter port |
| docs/development/container/Containerfile.dev | Updates commented conda env filename reference |
| docs/development/container/Containerfile | Switches conda env filename and adds meshplex runtime dependency install |
| docs/UWGeodynamics/examples/1_12_Uplift_TractionBCs.py | Adjusts np.isclose parameters for near-zero comparison |
| conda/environment.yaml | Switches Badlands dependency to PyPI package |
| clean.sh | Fixes __pycache__ cleanup glob |
| actions/globalprotect/scripts/entrypoint.sh | Removed (action deleted) |
| actions/globalprotect/action.yml | Removed (action deleted) |
| actions/globalprotect/README.md | Removed (action deleted) |
| actions/globalprotect/LICENSE | Removed (action deleted) |
| actions/globalprotect/Dockerfile | Removed (action deleted) |
| actions/globalprotect/.github/workflows/main.yml | Removed (action deleted) |
| Installation.rst | Updates documented Jupyter URL port |
| CHANGES.md | Adds a new release entry |
| .github/workflows/publish-to-pypi.yaml | Updates micromamba env filename reference |
| .github/workflows/issue-metrics.yml | Adds monthly issue-metrics workflow |
| .github/workflows/conda-build-test.yml | Updates action versions and micromamba env filename reference |
| .github/pull_request_template.md | Updates checklist reference from CHANGES to CHANGELOG |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # see https://micromamba-docker.readthedocs.io/en/latest/quick_start.html#quick-start | ||
| COPY --chown=$MAMBA_USER:$MAMBA_USER ./conda/environment.yaml /tmp/env.yaml | ||
| RUN micromamba install -y -v -n base -f /tmp/env.yaml && \ | ||
| COPY --chown=$MAMBA_USER:$MAMBA_USER ./conda/environment.yml /tmp/env.yml |
| uses: mamba-org/setup-micromamba@v3 | ||
| with: | ||
| environment-file: conda/environment.yaml | ||
| environment-file: conda/environment.yml |
| * Update the copyright information if necessary. | ||
| * Add new Binder link, and keep link to old Binder. | ||
| * Generate/update change log (`CHANGES.md`). | ||
| * Generate/update change log (`CHANGELOG.md`). |
| 3. All tests pass. | ||
| 4. Blog post update for significant changes. | ||
| 5. Update CHANGES.md. | ||
| 5. Update CHANGELOG.md. |
| - [ ] I have read the `CONTRIBUTING.rst` document. | ||
| - [ ] I have updated the docstrings accordingly. | ||
| - [ ] I have updated `CHANGES.md`. | ||
| - [ ] I have updated `CHANGELOG.md`. |
| podman build . --rm \ | ||
| --format docker \ | ||
| -f ./docs/developer/container/Containerfile \ | ||
| -f ./docs/development/container/Containerfile \ |
Comment on lines
+262
to
268
| event_dict = { "distinct_id" : _id, | ||
| "properties": { | ||
| "version" : underworld.__version__, | ||
| "platform" : sysinfo, | ||
| "run_size" : underworld.mpi.size, | ||
| "distinct_id" : _id, | ||
| } | ||
| "run_size" : underworld.mpi.size, | ||
| }, | ||
| } |
| uses: github-community-projects/issue-metrics@v4 | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GH_TOKEN }} | ||
| SEARCH_QUERY: 'repo:underworldcode/underworld2 underworldcode/underworld3 is:issue created:${{ env.last_month }} -reason:"not planned"' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
CONTRIBUTING.rstdocument.CHANGES.md.