fix(stealth): use Stealth class from playwright-stealth 2.x#1960
Open
NaabZer wants to merge 1 commit intounclecode:developfrom
Open
fix(stealth): use Stealth class from playwright-stealth 2.x#1960NaabZer wants to merge 1 commit intounclecode:developfrom
NaabZer wants to merge 1 commit intounclecode:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1959.
StealthAdapter._check_stealth_availabilityimportedstealth_async/stealth_syncfromplaywright_stealth, which 2.x doesn't expose. Replaced with theStealthclass —apply_stealth_asyncacceptsPageorBrowserContext, so existing call sites are unchanged.Changes
crawl4ai/browser_adapter.py— Swap the broken function-style imports forStealth().apply_stealth_async(page).Test plan
Ran the issue's repro against
develop(broken) and this branch (fixed), withenable_stealth=Falseas the control:enable_stealth=Falseenable_stealth=Truedevelopnavigator.languages: ["en-US"]navigator.languages: ["en-US"]← stealth=True is a no-opnavigator.languages: ["en-US"]navigator.languages: ["en-US","en"]←Stealthinit script appliedThe added
"en"isStealth()'s defaultnavigator_languages_override— proves the init script is now being injected. On Chromium 147 headless-shell most other classic signals (navigator.webdriver,chrome.csi/loadTimes, etc.) are already masked by the browser itself, so this is the clearest single-property A/B differentiator.developand this branchStealth.apply_stealth_asyncacceptsPage(signature:Union[Page, BrowserContext]) — no call-site changes needed inbrowser_manager.py