-
Notifications
You must be signed in to change notification settings - Fork 1
Never block agents: close-via-update, semantic fallback, create form, calendar --date crash #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| id: pm-7rlp | ||
| title: "CI/CD + test-suite performance: in-process CLI runner and dedupe redundant matrix legs" | ||
| description: "CI/test audit. Biggest win: ~1,500+ real 'node dist/cli.js' subprocess spawns dominate the 1414-test suite (742 runCli sites + 757 withTempPmPath inits; cold spawn ~35-44ms each). Add an in-process runner that calls main(argv) directly (capture stdout/stderr, reset module state), keep a small set of true-subprocess E2E tests; convert help-runtime + release-readiness + the bulk of unit specs. CI: the full suite runs 2-4x per run because build-test matrix legs run 'pnpm test' while gates(coverage) runs the same suite + coverage; on PR/push run ubuntu-20 coverage as authoritative and move the OS x Node compat matrix to nightly only; dedupe 'npm pack --dry-run' between static and smokes. Keep the 100% coverage gate. Free GitHub features only. Auto-release change-detection was audited and is CORRECT (no bug)." | ||
| type: Chore | ||
| status: open | ||
| priority: 1 | ||
| tags[3]: ci,performance,tests | ||
| created_at: "2026-05-21T21:57:10.762Z" | ||
| updated_at: "2026-05-21T21:57:10.762Z" | ||
| author: claude-code-agent | ||
| acceptance_criteria: Suite wall-time cut substantially via in-process runner; CI removes redundant full-suite legs; 100% coverage gate intact; nightly retains full OS/Node matrix. | ||
| parent: pm-rnpb | ||
| body: "" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| id: pm-b7do | ||
| title: "Remove dead code: command-aware.ts module, 5 orphaned exported functions, unused undici dependency" | ||
| description: "Code-quality audit (grep-verified zero call sites). Deleted src/core/output/command-aware.ts (389 LOC, orphaned by commit 5211414a; was explicitly allowlisted in static-quality-gate as zero-incoming-import). Removed dead exports getActiveCommandContext, applyDynamicExtensionOptions, normalizeCalendarOptions, listDocumentedHelpPaths, uniqueTokens. Removed unused direct dependency undici (^8.1.0; zero imports, only transitive undici@6 via @sentry/node remains). Updated the coverage-include allowlist and static-gate allowlist accordingly." | ||
| type: Chore | ||
| status: closed | ||
| priority: 2 | ||
| tags[3]: code-quality,dead-code,refactor | ||
| created_at: "2026-05-21T21:56:52.288Z" | ||
| updated_at: "2026-05-21T22:09:30.435Z" | ||
| author: claude-code-agent | ||
| acceptance_criteria: All dead symbols removed with zero remaining references; build/typecheck/static-gate green; 100% coverage maintained. | ||
| parent: pm-rnpb | ||
| close_reason: "Removed src/core/output/command-aware.ts (389 LOC) + 5 orphaned exports + unused undici dep; updated coverage-include and static-gate allowlists. Build/typecheck/static-gate green, 100% coverage maintained." | ||
| body: "" | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| id: pm-fu5d | ||
| title: "Dogfood 2026-05-21 follow-ups: test --add key validation, semantic-fallback labeling, close active-children info, stale blocker on close" | ||
| description: "Manual dogfood findings not yet fixed (separate from pm-5k2w which holds the 2026-05-20 polish backlog). B2 [med]: pm test --add 'cmd=...,name=...' silently stores the whole pair as the command - reject/warn unknown keys, accept cmd as alias for command. S1 [med]: when no embedding provider is configured but ollama auto-defaults engage, search reports mode:semantic with no warning even though embedded_items=0 - clarify degraded/lexical state. C3 [med]: closing a parent/epic with active children under minimal governance is silent - emit an informational closed_with_active_children warning even when not blocking. C4 [low]: closed items retain blocked_by metadata - clear/annotate on terminal transition. U2 [low]: did-you-mean missing for unknown options (--statuss). U3 [low]: accept --list as alias for --explore on package/extension. CAL1 [med]: support compound relative event times (start=+1d,end=+1d+2h) or a duration= field." | ||
| type: Chore | ||
| status: open | ||
| priority: 3 | ||
| tags[3]: agent-ux,dogfood,polish | ||
| created_at: "2026-05-21T21:57:44.257Z" | ||
| updated_at: "2026-05-21T21:57:44.257Z" | ||
| author: claude-code-agent | ||
| acceptance_criteria: Each listed finding is fixed or explicitly deferred with rationale; no agent-blocking introduced. | ||
| parent: pm-rnpb | ||
| body: "" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| id: pm-rjgh | ||
| title: "Docs hygiene: stop shipping PRD.md in npm package, dedupe PRD<->docs, slim CHANGELOG, reconcile marketplace.json" | ||
| description: Docs audit. PRD.md (118KB) is in package.json files and ships to every install while duplicating docs/ (commands/architecture/search/extensions/testing) and drifting from them; remove from published files and trim/relink it. CHANGELOG.md (71KB) is bloated by the 2026.5.3-1..8 same-day cluster; collapse to one entry. Root marketplace.json and .claude-plugin/marketplace.json have drifted (root lacks metadata/category) - reconcile from a single source (both have contract/smoke coupling). Tighten AGENTS.md to defer workflow detail to docs/AGENT_GUIDE.md. No private-infra leaks found in tracked docs (verified). | ||
| type: Chore | ||
| status: open | ||
| priority: 2 | ||
| tags[3]: cleanup,docs,packaging | ||
| created_at: "2026-05-21T21:57:15.117Z" | ||
| updated_at: "2026-05-21T21:57:15.117Z" | ||
| author: claude-code-agent | ||
| acceptance_criteria: PRD.md not in published package; CHANGELOG slimmed; marketplace.json files reconciled with contract+smoke green; no doc drift. | ||
| parent: pm-rnpb | ||
| body: "" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {"ts":"2026-05-21T21:57:10.762Z","author":"claude-code-agent","op":"create","patch":[{"op":"add","path":"/metadata/id","value":"pm-7rlp"},{"op":"add","path":"/metadata/title","value":"CI/CD + test-suite performance: in-process CLI runner and dedupe redundant matrix legs"},{"op":"add","path":"/metadata/description","value":"CI/test audit. Biggest win: ~1,500+ real 'node dist/cli.js' subprocess spawns dominate the 1414-test suite (742 runCli sites + 757 withTempPmPath inits; cold spawn ~35-44ms each). Add an in-process runner that calls main(argv) directly (capture stdout/stderr, reset module state), keep a small set of true-subprocess E2E tests; convert help-runtime + release-readiness + the bulk of unit specs. CI: the full suite runs 2-4x per run because build-test matrix legs run 'pnpm test' while gates(coverage) runs the same suite + coverage; on PR/push run ubuntu-20 coverage as authoritative and move the OS x Node compat matrix to nightly only; dedupe 'npm pack --dry-run' between static and smokes. Keep the 100% coverage gate. Free GitHub features only. Auto-release change-detection was audited and is CORRECT (no bug)."},{"op":"add","path":"/metadata/type","value":"Chore"},{"op":"add","path":"/metadata/status","value":"open"},{"op":"add","path":"/metadata/priority","value":1},{"op":"add","path":"/metadata/tags","value":["ci","performance","tests"]},{"op":"add","path":"/metadata/created_at","value":"2026-05-21T21:57:10.762Z"},{"op":"add","path":"/metadata/updated_at","value":"2026-05-21T21:57:10.762Z"},{"op":"add","path":"/metadata/author","value":"claude-code-agent"},{"op":"add","path":"/metadata/acceptance_criteria","value":"Suite wall-time cut substantially via in-process runner; CI removes redundant full-suite legs; 100% coverage gate intact; nightly retains full OS/Node matrix."},{"op":"add","path":"/metadata/parent","value":"pm-rnpb"}],"before_hash":"3cc22dff72be7b14824654a7a64ea62b04799939b2fee54c1b5f52ca60bf6df0","after_hash":"c936a2b2f2c7e8fd09962b4f6965c8b9b7409a02a547a11e5830728e36467be9","message":""} |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| {"ts":"2026-05-21T21:56:52.288Z","author":"claude-code-agent","op":"create","patch":[{"op":"add","path":"/metadata/id","value":"pm-b7do"},{"op":"add","path":"/metadata/title","value":"Remove dead code: command-aware.ts module, 5 orphaned exported functions, unused undici dependency"},{"op":"add","path":"/metadata/description","value":"Code-quality audit (grep-verified zero call sites). Deleted src/core/output/command-aware.ts (389 LOC, orphaned by commit 5211414a; was explicitly allowlisted in static-quality-gate as zero-incoming-import). Removed dead exports getActiveCommandContext, applyDynamicExtensionOptions, normalizeCalendarOptions, listDocumentedHelpPaths, uniqueTokens. Removed unused direct dependency undici (^8.1.0; zero imports, only transitive undici@6 via @sentry/node remains). Updated the coverage-include allowlist and static-gate allowlist accordingly."},{"op":"add","path":"/metadata/type","value":"Chore"},{"op":"add","path":"/metadata/status","value":"open"},{"op":"add","path":"/metadata/priority","value":2},{"op":"add","path":"/metadata/tags","value":["code-quality","dead-code","refactor"]},{"op":"add","path":"/metadata/created_at","value":"2026-05-21T21:56:52.288Z"},{"op":"add","path":"/metadata/updated_at","value":"2026-05-21T21:56:52.288Z"},{"op":"add","path":"/metadata/author","value":"claude-code-agent"},{"op":"add","path":"/metadata/acceptance_criteria","value":"All dead symbols removed with zero remaining references; build/typecheck/static-gate green; 100% coverage maintained."},{"op":"add","path":"/metadata/parent","value":"pm-rnpb"}],"before_hash":"3cc22dff72be7b14824654a7a64ea62b04799939b2fee54c1b5f52ca60bf6df0","after_hash":"114abd429fbb6a720519fa04c0bc0fa58f132091ade15557b20eefe4c30c2a16","message":""} | ||
| {"ts":"2026-05-21T22:09:30.435Z","author":"claude-code-agent","op":"close","patch":[{"op":"replace","path":"/metadata/updated_at","value":"2026-05-21T22:09:30.435Z"},{"op":"replace","path":"/metadata/status","value":"closed"},{"op":"add","path":"/metadata/close_reason","value":"Removed src/core/output/command-aware.ts (389 LOC) + 5 orphaned exports + unused undici dep; updated coverage-include and static-gate allowlists. Build/typecheck/static-gate green, 100% coverage maintained."}],"before_hash":"114abd429fbb6a720519fa04c0bc0fa58f132091ade15557b20eefe4c30c2a16","after_hash":"64d5feb49a9d69fdf3e4023b3fb1dc6be239240589c9edc36822dcd5c8a6b923"} | ||
|
Comment on lines
+1
to
+2
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do not create This history file should be managed by the pm tool, not manually created or edited in the repository. As per coding guidelines, As per coding guidelines: " 🤖 Prompt for AI Agents |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {"ts":"2026-05-21T21:57:44.257Z","author":"claude-code-agent","op":"create","patch":[{"op":"add","path":"/metadata/id","value":"pm-fu5d"},{"op":"add","path":"/metadata/title","value":"Dogfood 2026-05-21 follow-ups: test --add key validation, semantic-fallback labeling, close active-children info, stale blocker on close"},{"op":"add","path":"/metadata/description","value":"Manual dogfood findings not yet fixed (separate from pm-5k2w which holds the 2026-05-20 polish backlog). B2 [med]: pm test --add 'cmd=...,name=...' silently stores the whole pair as the command - reject/warn unknown keys, accept cmd as alias for command. S1 [med]: when no embedding provider is configured but ollama auto-defaults engage, search reports mode:semantic with no warning even though embedded_items=0 - clarify degraded/lexical state. C3 [med]: closing a parent/epic with active children under minimal governance is silent - emit an informational closed_with_active_children warning even when not blocking. C4 [low]: closed items retain blocked_by metadata - clear/annotate on terminal transition. U2 [low]: did-you-mean missing for unknown options (--statuss). U3 [low]: accept --list as alias for --explore on package/extension. CAL1 [med]: support compound relative event times (start=+1d,end=+1d+2h) or a duration= field."},{"op":"add","path":"/metadata/type","value":"Chore"},{"op":"add","path":"/metadata/status","value":"open"},{"op":"add","path":"/metadata/priority","value":3},{"op":"add","path":"/metadata/tags","value":["agent-ux","dogfood","polish"]},{"op":"add","path":"/metadata/created_at","value":"2026-05-21T21:57:44.257Z"},{"op":"add","path":"/metadata/updated_at","value":"2026-05-21T21:57:44.257Z"},{"op":"add","path":"/metadata/author","value":"claude-code-agent"},{"op":"add","path":"/metadata/acceptance_criteria","value":"Each listed finding is fixed or explicitly deferred with rationale; no agent-blocking introduced."},{"op":"add","path":"/metadata/parent","value":"pm-rnpb"}],"before_hash":"3cc22dff72be7b14824654a7a64ea62b04799939b2fee54c1b5f52ca60bf6df0","after_hash":"b355a4216c6b90499d1a2368e1974b39ce71e1c2f3356e09ae665e133c28c280","message":""} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not create
.agents/pmfiles directly.This file should be managed by the pm tool, not manually created or edited in the repository. As per coding guidelines,
.agents/pm/**files are the system of record and should not be edited directly.As per coding guidelines: "
.agents/pm/**: pm is the system of record. Do not edit.agents/pmfiles directly."🤖 Prompt for AI Agents