Skip to content

[codex] Improve agent UX from manual pm audit #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
unbraind merged 3 commits into from
May 21, 2026
Merged

[codex] Improve agent UX from manual pm audit #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d67eb2
Improve agent UX from manual pm audit
unbraind May 21, 2026
50ccfed
Address review feedback for audit UX fixes
unbraind May 21, 2026
c52719e
Fix extension contract alias availability
unbraind May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 37 additions & 1 deletion .agents/pm/chores/pm-5k2w.toon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,44 @@ status: open
priority: 3
tags[5]: agent-ux,cli,docs,dogfood,polish
created_at: "2026-05-20T20:33:06.671Z"
updated_at: "2026-05-20T20:33:06.671Z"
updated_at: "2026-05-21T05:12:26.530Z"
author: claude-code-agent
acceptance_criteria: Each listed sub-item is either fixed with a regression test or explicitly declined with rationale; no change drops coverage below 100%; doc/validator drift (L6) resolved; default-safety inconsistencies (L10) reviewed.
parent: pm-rnpb
comments[5]{created_at,author,text}:
"2026-05-21T04:30:32.081Z",codex-full-manual-audit,"Evidence: focused manual smoke passed config list shorthand, cal week positional view, close active-child warning, gc reindex install guidance, and PM_NO_TELEMETRY health reporting. Local checks passed so far: pnpm build; focused 7-file suite 37 tests after calendar runtime fix and 6-file suite 129 tests before that; pnpm quality:static; node scripts/check-secrets.mjs."
"2026-05-21T04:40:05.493Z",codex-full-manual-audit,"Evidence: full release gate passed after stale GC expectation update. Passed build, typecheck, docs-skills, static quality, coverage 96 files / 1399 tests at 100 percent, version policy, secret scan, npx packed smoke, package-first dogfood 84 workflows, npm pack dry-run, compatibility, and required Sentry/telemetry gate with Sentry critical=0 high=1 and telemetry finish_error_rate_pct=2.71."
"2026-05-21T04:42:28.101Z",codex-full-manual-audit,"Pause evidence: focused subset fixed and release-gated. Fixed config list shorthand, calendar positional view handling, GC missing-reindex guidance, PM_NO_TELEMETRY opt-out reporting/runtime, invalid dependency kind recovery, close active-child warning, and extension contract metadata/alias dedupe. Remaining backlog items on this chore stay open: init verbosity, help alias display bloat, create changed_fields noise, calendar include scheduled doc drift, guide install hints, priority wording drift, template starter content, broader default-safety review, and event equal-timestamp hinting. Full gate passed with run-gates telemetry-mode required and 100% selected coverage."
"2026-05-21T05:03:41.138Z",codex-full-manual-audit,"PR review response evidence: addressed valid CodeRabbit/Sourcery feedback by shifting config shorthand keys correctly, validating extension flag value_type fallback before using valueName string fallback, making merged extension x-extension-command deterministic while exposing x-extension-commands, merging duplicate flag metadata predictably, using merged extension contracts for action descriptors and alias-aware command catalog, and adding PM_NO_TELEMETRY health coverage. Focused review-fix suite passed: 3 files, 26 tests; tsc --noEmit passed."
"2026-05-21T05:12:26.530Z",codex-full-manual-audit,"CI fix evidence: PR run 26206567968 exposed alias availability regression where merged command_path values like cal|calendar and test-runs aliases were treated as one literal command. Fixed contract command-path matching, scoped-command derivation, and extension availability to split alias groups. Verification passed: calendar/contracts/health focused suite 64 tests, tsc --noEmit, and node scripts/dogfood-package-first.mjs 84 commands."
files[20]{path,scope,note}:
packages/pm-calendar/extensions/calendar/index.js,project,compiled calendar package entry kept in sync
packages/pm-calendar/extensions/calendar/index.ts,project,calendar positional view support
src/cli/commands/close.ts,project,close validation warns on active children
src/cli/commands/contracts.ts,project,extension action schema aliases and flag metadata
src/cli/commands/gc.ts,project,gc reindex install guidance
src/cli/commands/health.ts,project,health reports PM_NO_TELEMETRY alias
src/cli/commands/update.ts,project,dependency kind recovery lists allowed values
src/cli/main.ts,project,dynamic extension command action arg handling
src/cli/register-setup.ts,project,config action shorthand for agent UX
src/core/telemetry/runtime.ts,project,PM_NO_TELEMETRY opt-out alias
src/sdk/cli-contracts.ts,project,extension flag contract metadata
tests/integration/cli.integration.spec.ts,project,Regression test for config action shorthand key shifting
tests/unit/builtin-extension-entrypoints.spec.ts,project,Built-in extension entrypoint smoke coverage
tests/unit/calendar-command.spec.ts,project,Calendar positional view smoke coverage
tests/unit/close-command.spec.ts,project,Regression test for active-child close warning
tests/unit/contracts-command.spec.ts,project,Regression tests for extension contract metadata and alias dedupe
tests/unit/gc-command.spec.ts,project,gc guidance regression coverage
tests/unit/health-command.spec.ts,project,Regression test for telemetry env override reporting
tests/unit/telemetry-runtime.spec.ts,project,Regression test for PM_NO_TELEMETRY opt-out
tests/unit/update-command.spec.ts,project,Regression test for dependency kind guidance
tests[8]{command,path,scope,timeout_seconds,pm_context_mode,env_set,env_clear,shared_host_safe,assert_stdout_contains,assert_stdout_regex,assert_stderr_contains,assert_stderr_regex,assert_stdout_min_lines,assert_json_field_equals,assert_json_field_gte,note}:
node scripts/check-secrets.mjs,null,project,120,null,null,null,null,null,null,null,null,null,null,null,null
node scripts/release/run-gates.mjs --telemetry-mode required --max-sentry-critical 10 --max-sentry-high 20 --max-telemetry-error-rate 10 --json,null,project,420,null,null,null,null,null,null,null,null,null,null,null,null
PM_RUN_TESTS_SKIP_BUILD=1 node scripts/run-tests.mjs test -- tests/unit/calendar-command.spec.ts tests/unit/contracts-command.spec.ts tests/unit/health-command.spec.ts --reporter=dot,null,project,240,null,null,null,null,null,null,null,null,null,null,null,null
"PM_RUN_TESTS_SKIP_BUILD=1 node scripts/run-tests.mjs test -- tests/unit/contracts-command.spec.ts tests/unit/health-command.spec.ts tests/integration/cli.integration.spec.ts -t \"extension|PM_NO_TELEMETRY|config\" --reporter=dot",null,project,240,null,null,null,null,null,null,null,null,null,null,null,null
PM_RUN_TESTS_SKIP_BUILD=1 node scripts/run-tests.mjs test -- tests/unit/contracts-command.spec.ts tests/unit/health-command.spec.ts tests/unit/telemetry-runtime.spec.ts tests/unit/update-command.spec.ts tests/unit/close-command.spec.ts tests/unit/calendar-command.spec.ts tests/unit/builtin-extension-entrypoints.spec.ts --reporter=dot,null,project,180,null,null,null,null,null,null,null,null,null,null,null,null
PM_RUN_TESTS_SKIP_BUILD=1 node scripts/run-tests.mjs test -- tests/unit/gc-command.spec.ts tests/unit/calendar-command.spec.ts --reporter=dot,null,project,120,null,null,null,null,null,null,null,null,null,null,null,null
pnpm build,null,project,120,null,null,null,null,null,null,null,null,null,null,null,null
"pnpm quality:static",null,project,120,null,null,null,null,null,null,null,null,null,null,null,null
body: ""
9 changes: 6 additions & 3 deletions .agents/pm/features/pm-rnpb.toon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,15 @@ status: in_progress
priority: 0
tags[10]: agent-ux,audit,calendar,ci,dogfood,pm-cli,sdk,search,security,telemetry
created_at: "2026-05-03T13:20:01.343Z"
updated_at: "2026-05-20T22:23:02.164Z"
updated_at: "2026-05-21T04:42:33.995Z"
deadline: "2026-06-01T00:00:00.000Z"
assignee: codex-audit-2026-05-20
author: codex-audit
estimated_minutes: 300
acceptance_criteria: Audit findings are actionable and deduplicated; changed files and verification commands are linked; temporary dogfood project validates core workflows; any discovered bugs with safe fixes are remediated and tested.
parent: pm-jrjt
dependencies[1]{id,kind,created_at,author,source_kind}:
pm-jrjt,parent,"2026-05-03T13:20:01.343Z",codex-audit,null
comments[155]{created_at,author,text}:
comments[159]{created_at,author,text}:
"2026-05-03T13:20:01.343Z",codex-audit,Parent lineage established under pm-jrjt after duplicate checks found only closed prior audit items.
"2026-05-09T11:12:26.232Z",codex-agent,"Duplicate check before this pass: pm context --limit 10 --depth standard, pm search dogfood audit extensible sdk calendar semantic search telemetry sentry --limit 10, pm list-open --limit 20, and pm list-in-progress --limit 20. Reusing open feature pm-rnpb; prior same-day task pm-m35h is closed, so no duplicate item created."
"2026-05-09T11:46:59.430Z",codex-agent,"Evidence 2026-05-09: temp dogfood project exercised init/create/claim/update/files/docs/tests/calendar/context/aggregate/dedupe/search/reindex/extension scaffold/install/doctor/contracts/manage. Fixed search gap discovered there: reminder/event metadata is now in keyword and semantic corpus, and short phrase scoring ranks exact calendar event titles first. Verification passed: focused search/reindex/cache tests, release-readiness/search focused tests, linked pm test, full 100% coverage, static quality gate, CI workflow contract tests, pm health, pm validate, npm pack dry-run, secret scan, live telemetry/Sentry checks, and real hybrid reindex of 679 items."
Expand Down Expand Up @@ -171,6 +170,10 @@ comments[155]{created_at,author,text}:
"2026-05-20T22:10:49.653Z",codex-full-audit,"PR evidence 2026-05-20: pushed branch audit/token-output-activity-history-2026-05-20 commit 50d80641 and opened PR #35 (https://github.com/unbraind/pm-cli/pull/35) for compact history/activity output, semantic gc cleanup, and dynamic flag validation. Local gates passed before push: build, focused regression, full coverage 100%, static quality, secret scan. Watching CI and review-bot feedback before merge."
"2026-05-20T22:20:23.463Z",codex-full-audit,"PR #35 review feedback addressed: Sourcery noted normalizeActivityOptions ignored explicit compact=false when full was absent; Gemini noted extension subcommand flag lookup precedence. Patched activity compact precedence and made nested extension command flag definitions win over group-level matches. Focused verification passed: PM_RUN_TESTS_SKIP_BUILD=1 node scripts/run-tests.mjs test -- tests/integration/cli.integration.spec.ts tests/unit/main-loose-options.spec.ts tests/unit/history-activity-command.spec.ts tests/integration/mcp-dynamic-package-actions.spec.ts --reporter=dot (4 files, 102 tests); pnpm exec tsc --noEmit passed."
"2026-05-20T22:23:02.164Z",codex-full-audit,"PR #35 CodeRabbit follow-up addressed: preserved alias values when both canonical and alias extension flags are supplied, while keeping nested extension flag precedence. Focused verification passed again: PM_RUN_TESTS_SKIP_BUILD=1 node scripts/run-tests.mjs test -- tests/unit/main-loose-options.spec.ts tests/integration/cli.integration.spec.ts tests/unit/history-activity-command.spec.ts tests/integration/mcp-dynamic-package-actions.spec.ts --reporter=dot (4 files, 102 tests); pnpm exec tsc --noEmit passed."
"2026-05-21T04:11:00.194Z",codex-full-manual-audit,"Investigation note: Reusing existing canonical audit item after duplicate check. Scope covers full latest-build manual temp-project dogfood, CLI/SDK/calendar/search/performance/security/CI review, GitHub issue/PR/dependency review, telemetry/Sentry analysis, and targeted fixes discovered during the run."
"2026-05-21T04:17:16.756Z",codex-full-manual-audit,"Sub-agent/manual audit findings mapped without duplicate items: reuse pm-5k2w for config/calendar/telemetry/dependency/gc polish, pm-59gj for multi-package install/catalog UX, pm-rnpb for semantic provider staleness and auto-index provider parity, pm-orrl for blocked-by semantics, pm-nbht for health brevity, and pm-gt82/pm-mbdu for startup and large-file follow-ups."
"2026-05-21T04:40:06.326Z",codex-full-manual-audit,"Evidence: latest sub-agent/manual audit and fixes completed under pm-5k2w. Dogfood passed normal 84 workflows and semantic 86 workflows using qwen3-embedding:0.6b; release gate passed with coverage 96 files / 1399 tests at 100 percent and required Sentry/telemetry gate. Residual performance/coverage breadth/semantic provider-staleness findings remain mapped to existing pm-rnpb/pm-gt82/pm-mbdu/pm-59gj follow-ups, not duplicated."
"2026-05-21T04:42:32.110Z",codex-full-manual-audit,"Audit closeout evidence: broad manual dogfood and sub-agent review completed for this slice. Local release gate passed with telemetry required, package-first dogfood passed including semantic qwen Ollama mode, Sentry/telemetry gate passed against current baseline, GitHub issue/PR/vulnerability scan found no open actionable GitHub items. Residuals remain tracked under existing lineage: broader read-path performance, semantic provider staleness/auto-index parity, CI duration reduction beyond current selected coverage gate, and telemetry queue backlog investigation."
notes[2]{created_at,author,text}:
"2026-05-17T07:36:59.474Z",codex-agent,"Design note 2026-05-17: unfiltered pm contracts default now intentionally omits three heavy sections (schema oneOf union, command_flags, commander_aliases) and emits explicit omitted_reason markers; --full restores complete schema and alias/flag surfaces for tooling that needs maximal detail."
"2026-05-17T08:33:25.981Z",codex-agent,"Design note 2026-05-17: default brief projection was intentionally scoped to bare 'pm list' instead of all list-* commands to preserve existing automation contracts while still cutting agent token usage on the highest-frequency exploratory list call."
Expand Down
Loading