Skip to content

Conversation

@erikjanwestendorp
Copy link
Contributor

📋 Description

Add a note as suggested here:

#7095

@sofietoft
Copy link
Contributor

Thanks for the PR @erikjanwestendorp !

I'll make sure we have this reviewed as soon as possible.

Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a sensible addition to me @erikjanwestendorp, thanks for proposing.

My only question is where you say "Ensure Umbraco reads these forwarded headers", you aren't also saying or linking as to how I would do this. Or, if there's nothing more to do other than is already described in the document, perhaps you don't need this part of the last sentence, and could just say something like "This will prevent all requests appearing to come from from one IP address which would cause incorrect rate-limit enforcement.".

@sofietoft
Copy link
Contributor

Also, I notice there's a merge conflict.
It's most likely due to the fact that the version 15 docs have been unpublished as it has reached end-of-life.
Taking the 15 article out of the PR, will resolve the issue! 💪

@erikjanwestendorp
Copy link
Contributor Author

@sofietoft thanks for the suggestion, just updated the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants