-
Notifications
You must be signed in to change notification settings - Fork 816
Update api rate limiting #7696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update api rate limiting #7696
Conversation
|
Thanks for the PR @erikjanwestendorp ! I'll make sure we have this reviewed as soon as possible. |
AndyButland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks a sensible addition to me @erikjanwestendorp, thanks for proposing.
My only question is where you say "Ensure Umbraco reads these forwarded headers", you aren't also saying or linking as to how I would do this. Or, if there's nothing more to do other than is already described in the document, perhaps you don't need this part of the last sentence, and could just say something like "This will prevent all requests appearing to come from from one IP address which would cause incorrect rate-limit enforcement.".
|
Also, I notice there's a merge conflict. |
Co-authored-by: sofietoft <stk@umbraco.com>
|
@sofietoft thanks for the suggestion, just updated the PR. |
📋 Description
Add a note as suggested here:
#7095