feat: PLAT-000 Add docker-login support for zendesk-base-images#102
Merged
Conversation
07da838 to
c8ccfe1
Compare
e3538a9 to
7991c99
Compare
7991c99 to
7537016
Compare
hosseinkarjoo
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zendesk-base-images are served from europe-west1-docker.pkg.dev repository
this pr adds support for docker-login action to authenticate to the above repository, in turn this will allow Dockerfile images based on zendesk-base-images to be used.
for all other use cases like docker.io nothing will change