Extend the small inverse pow5 offset table #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-packard
force-pushed
the
extend-small-inv-table
branch
from
12a63e0 to
e20b956
Compare
The maximum value for the invPow5 function is 342, which means the offset table needs 342 * 2 = 684 bits or > 21 32-bit values. Add the missing values by computing them based off the full table values. Signed-off-by: Keith Packard <keithp@keithp.com>
keith-packard
force-pushed
the
extend-small-inv-table
branch
from
e20b956 to
78e3e5b
Compare
Owner
|
It would be good to add tests for this case; are there numbers that don't work correctly due to the missing entries? |
Author
|
There are cases which access beyond the bounds of the array; that's what I discovered when I enabled array bounds checking and ran my test suite. I'm not sure I can easily re-create that situation though, it's been a long time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maximum value for the invPow5 function is 342, which means the offset table needs 342 * 2 = 684 bits or > 21 32-bit values. Add the missing values by computing them based off the full table values.