Conversation
345fc08 to
c0cf3a4
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4114 +/- ##
==========================================
- Coverage 46.88% 46.19% -0.70%
==========================================
Files 136 137 +1
Lines 29253 29895 +642
==========================================
+ Hits 13715 13809 +94
- Misses 15538 16086 +548 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
je-cook
left a comment
There was a problem hiding this comment.
I think a lot of this can be done far more concisely. Being this long makes is much harder to follow. My estimate is <1000 lines.
Please use dataclasses where appropriate and include less in the overall class.
I would also guess that most of the methods are not individually useful to a user. Please have a think about what is a useful API to expose to the user in the classes and only make methods for that
|
|
||
| for i, psi_norm in enumerate(psi_norm_mesh): | ||
| # Use this instead of matplotlib.contour as the latter forces figure creation. | ||
| contour = measure.find_contours(psi_bar_norm_grid, level=psi_norm) |
There was a problem hiding this comment.
just use contourpy directly, then we dont need the new dependency as it already comes with mpl
…ion and property management
This pull request expands the plotting functionality in
process/io/plot_proc.pyby adding a new analytic equilibrium plot and updating the figure indexing throughout the main plotting routine to accommodate the additional plot. The changes ensure all plots are correctly assigned to their respective figure pages and axes.New analytic equilibrium plot:
plot_analytic_equilibriumfromprocess.models.physics.solovev_equilibriumand integrated its plotting into the main plotting routine, providing visualization of the analytic equilibrium. [1] [2]Plot indexing and figure allocation updates:
mainfunction to accommodate the new plot.main_plotfunction to ensure each plot is placed on the correct page and axis, maintaining layout consistency after the addition of the new plot.Checklist
I confirm that I have completed the following checks: